Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 9481008: Move GenericHandler back to Chrome since it was really Chrome specific (i.e. chrome's mapping of cl… (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move GenericHandler back to Chrome since it was really Chrome specific (i.e. chrome's mapping of click to disposition). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123801

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -180 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/disposition_utils.h View 2 chunks +8 lines, -10 lines 0 comments Download
A + chrome/browser/disposition_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/event_disposition.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/event_utils.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/event_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +6 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/generic_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/generic_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
D content/browser/disposition_utils.h View 1 chunk +0 lines, -26 lines 0 comments Download
D content/browser/disposition_utils.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D content/browser/webui/generic_handler.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/browser/webui/generic_handler.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 10 months ago (2012-02-27 19:09:08 UTC) #1
Avi (use Gerrit)
There seem to be three sets of changes here. One is the GenericHandler, but there's ...
8 years, 10 months ago (2012-02-27 19:27:16 UTC) #2
jam
On 2012/02/27 19:27:16, Avi wrote: > There seem to be three sets of changes here. ...
8 years, 10 months ago (2012-02-27 20:10:58 UTC) #3
Avi (use Gerrit)
8 years, 10 months ago (2012-02-27 20:14:58 UTC) #4
Ah, I see. LGTM

Powered by Google App Engine
This is Rietveld 408576698