retry r123804 - ntp theme fixes

retry r123804 - ntp theme fixes

1. fix where the theme background is displayed for default (0) alignment -- it should be center center. This matches what the bookmar
1a. fix tests for alignment conversions
2. Fix the bookmark bar for vertical center alignment.
3. update the ntp background when the bookmark bar is attached/detached.

TODO: transition (3) so that it looks good on windows and mac.
BUG=115594
TEST=unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124014

[Evan Stade, 2012-02-28 02:17:23]

http://codereview.chromium.org/9477018/diff/1/chrome/browser/themes/theme_ser...
File chrome/browser/themes/theme_service_unittest.cc (right):

http://codereview.chromium.org/9477018/diff/1/chrome/browser/themes/theme_ser...
chrome/browser/themes/theme_service_unittest.cc:21: EXPECT_EQ("center top",
ThemeService::AlignmentToString(alignment));
we can't make it spit out the same thing we put in, because both "center top"
and "top" will be converted to ALIGN_TOP.

also, we can't leave it how it was, because plain ALIGN_CENTER was converted to
"", which defaults to "left top", not "center center".

[Dan Beam, 2012-02-28 02:28:51]

lgtm with trybots (which you seem to have, sans windows)

[commit-bot: I haz the power, 2012-02-28 02:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9477018/1

[commit-bot: I haz the power, 2012-02-28 03:13:41]

Try job failure for 9477018-1 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...