Allocate and finalize a code object on x64 if the new compiler succeeds.

Allocate and finalize a code object on x64 if the new compiler succeeds.

If the new compiler completed, use the code that it produced.

R=srdjan@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4674

[Kevin Millikin (Google), 2012-02-27 15:11:48]

This CL stands alone (though we bail out on everything because of the function's
scope).

When combined with

http://codereview.chromium.org/9471010/
http://codereview.chromium.org/9447102/

It passes all tests on x64.

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc#newcode149
runtime/vm/compiler.cc:149: const Code& code =
As long as the call to CompileGraph can bailout, I did not see a simple way to
share the common code that follows.

[srdjan, 2012-02-28 00:23:39]

LGTM with comments

http://codereview.chromium.org/9474001/diff/1/runtime/vm/code_generator_x64.cc
File runtime/vm/code_generator_x64.cc (right):

http://codereview.chromium.org/9474001/diff/1/runtime/vm/code_generator_x64.c...
runtime/vm/code_generator_x64.cc:222: bool check_ids) {
Move VerifyPcDescriptors out to shared code, e.g., make it a static in class
CodeGenerator::DescriptorList

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc#newcode129
runtime/vm/compiler.cc:129: int code_size = -1;  // Assembled code size needed
if --disassemble.
Remove code_size, you can get it from Instructions::size()

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc#newcode131
runtime/vm/compiler.cc:131: if (FLAG_use_new_compiler) {
FLAG_use_new_compiler && !optimized  or ASSERT (!optimized)

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc#newcode175
runtime/vm/compiler.cc:175: if (!is_compiled) {
This if is too long.  A suggestion:

if (optimized) {
  ASSERT(!is_compiled);
  ..
} else if (!is_compiled) {
  ...
}

[Kevin Millikin (Google), 2012-02-29 14:24:24]

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

http://codereview.chromium.org/9474001/diff/1/runtime/vm/compiler.cc#newcode129
runtime/vm/compiler.cc:129: int code_size = -1;  // Assembled code size needed
if --disassemble.
On 2012/02/28 00:23:39, srdjan wrote:
> Remove code_size, you can get it from Instructions::size()

Done.