Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 9463007: Ensure that outgoing constant arguments will be materialized. (Closed)

Created:
8 years, 10 months ago by Kevin Millikin (Google)
Modified:
8 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure that outgoing constant arguments will be materialized. This keeps the IL simple for the benefit of the optimizing compiler. It intentionally relies on a particular temporary allocation strategy for the non-optimizing compiler. For the dart function main() { var x = 2; hukairs(1, x, 3); } The flow graph is: 0: [target] StoreLocal(x, #2) t0 <-#1 t1 <-LoadLocal(x) t2 <-#3 StaticCall(hukairs, t0, t1, t2) return #null R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +21 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
I added a Translate helper for arguments lists rather than using VisitArgumentListNode because that function ...
8 years, 10 months ago (2012-02-24 11:27:56 UTC) #1
srdjan
8 years, 10 months ago (2012-02-24 15:35:40 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698