Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 9460039: ui/base: Remove the dependency in Profile from ThemeProvider. (Closed)

Created:
8 years, 10 months ago by tfarina
Modified:
8 years, 10 months ago
CC:
chromium-reviews, asanka, tfarina, Randy Smith (Not in Mondays), ben+watch_chromium.org
Visibility:
Public.

Description

ui/base: Remove the dependency in Profile from ThemeProvider. NOTE: This was a TODO for ben@. BUG=80197 R=ben@chromium.org TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123707

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M chrome/browser/themes/theme_service.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/theme_provider.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/widget/default_theme_provider.h View 3 chunks +2 lines, -5 lines 0 comments Download
M ui/views/widget/default_theme_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 10 months ago (2012-02-25 14:20:54 UTC) #1
Ben Goodger (Google)
8 years, 10 months ago (2012-02-27 01:38:09 UTC) #2
Cool. LGTM.

Powered by Google App Engine
This is Rietveld 408576698