Adding run_at to chrome.tabs.executeScript/insertCss.

chrome/renderer/extensions/user_script_idle_scheduler.h

Index: chrome/renderer/extensions/user_script_idle_scheduler.h
diff --git a/chrome/renderer/extensions/user_script_idle_scheduler.h b/chrome/renderer/extensions/user_script_idle_scheduler.h
index 782ce86974ea446e93b2fb9afcf73a0383dfe212..1767674ff480b76a4761f821d670638f8762e452 100644
--- a/chrome/renderer/extensions/user_script_idle_scheduler.h
+++ b/chrome/renderer/extensions/user_script_idle_scheduler.h
@@ -38,11 +38,16 @@ class WebFrame;
 // ExtensionDispatcher, which contains the mapping from WebFrame to us.
 class UserScriptIdleScheduler {

[Aaron Boodman, 2012/03/03 00:59:10]

Can you change the name of this class and rename the file to make it more
accurate? Usually rietveld is pretty good about detecting renames and not
marking the entire class new. If it fails, we can do it as a subsequent commit.

[eaugusti, 2012/03/27 00:43:34]

Done.

  public:
+  typedef

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

This typedef should be private.

[eaugusti, 2012/03/27 00:43:34]

Done.

+    std::vector<std::queue<linked_ptr<ExtensionMsg_ExecuteCode_Params> > >

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

Why not make this a map from RunLocation to the queue of code to execute? 

[eaugusti, 2012/03/27 00:43:34]

Done.

+    Schedule;
+
   UserScriptIdleScheduler(WebKit::WebFrame* frame,
                           ExtensionDispatcher* extension_dispatcher);
   ~UserScriptIdleScheduler();
 
   void ExecuteCode(const ExtensionMsg_ExecuteCode_Params& params);
+  void DidCreateDocumentElement();
   void DidFinishDocumentLoad();
   void DidFinishLoad();
   void DidStartProvisionalLoad();
@@ -60,6 +65,9 @@ class UserScriptIdleScheduler {
   bool GetAllChildFrames(WebKit::WebFrame* parent_frame,
                          std::vector<WebKit::WebFrame*>* frames_vector) const;
 
+  // Call to signify thet the idle timeout has expired.
+  void IdleTimeout();
+
   base::WeakPtrFactory<UserScriptIdleScheduler> weak_factory_;
 
   // The Frame we will run scripts in.
@@ -68,9 +76,13 @@ class UserScriptIdleScheduler {
   // Whether we have already run scripts.
   bool has_run_;
 
+  // The current location in the document lodaing process.

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

Typo ("lodaing").

[eaugusti, 2012/03/27 00:43:34]

Done.

+  // Will be -1 if it is before any scripts should be run.
+  // Otherwise it will be one of UserScript::RunLocation
+  int current_location_;
+
   // This is only used if we're for the main frame.
-  std::queue<linked_ptr<ExtensionMsg_ExecuteCode_Params> >
-      pending_code_execution_queue_;
+  Schedule pending_code_execution_queue_;
 
   ExtensionDispatcher* extension_dispatcher_;
 };