Proxy the PPP_Printing interface

Adds a printing proxy and example. This adds a printing example.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124149

[brettw, 2012-02-26 18:18:28]

I still need to do some manual testing but this is pretty straightforward and I
think is ready to review in parallel.

[viettrungluu, 2012-02-27 18:58:46]

LGTM w/2 nits.

http://codereview.chromium.org/9455083/diff/1/ppapi/proxy/ppp_printing_proxy.cc
File ppapi/proxy/ppp_printing_proxy.cc (right):

http://codereview.chromium.org/9455083/diff/1/ppapi/proxy/ppp_printing_proxy....
ppapi/proxy/ppp_printing_proxy.cc:33: memcpy(&settings_string[0],
print_settings, sizeof(PP_PrintSettings_Dev));
I suppose this is more aliasing-rules-correct than using/abusing the std::string
constructor that takes a const char* and a size_t. (But you could just do
|std::string settings_string(sizeof(*print_settings), 0);|.)

Nit: use |sizeof(*print_settings)| rather than hard-coding its type.

http://codereview.chromium.org/9455083/diff/1/ppapi/proxy/ppp_printing_proxy....
ppapi/proxy/ppp_printing_proxy.cc:45: std::vector<PP_PrintPageNumberRange_Dev>
pages;
You can just do:

std::vector<...> pages(page_ranges, page_ranges + range_count);

[brettw, 2012-02-28 00:02:04]

This includes an example and fixes the associated bugs.

The BeginPrint return value wasn't being returned properly. I also had to fix up
the refcounting on the returned interface.

[viettrungluu, 2012-02-28 00:11:43]

LGTM, I think?

http://codereview.chromium.org/9455083/diff/3002/ppapi/examples/printing/prin...
File ppapi/examples/printing/printing.cc (right):

http://codereview.chromium.org/9455083/diff/3002/ppapi/examples/printing/prin...
ppapi/examples/printing/printing.cc:53: FillRect(&image, 0, 0, size.width(),
size.height(), 0xFFFFFFFF);
This will blow up in spectacular fashion if the image data fails to get created,
which could happen.

[viettrungluu, 2012-02-28 00:16:48]

You didn't add anything to build the example.

[commit-bot: I haz the power, 2012-02-28 21:20:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/9455083/15001

[commit-bot: I haz the power, 2012-02-28 22:42:51]

Try job failure for 9455083-15001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-29 05:03:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/9455083/15001

[commit-bot: I haz the power, 2012-02-29 07:54:20]

Change committed as 124149