Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 9455083: Proxy the PPP_Printing interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/resource_tracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 1b6ff947aa7bfd1d22902ab6df17623914cb52df..7dde8d740c2b559324b1f65c7b4a69f9be1c110e 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -1513,11 +1513,7 @@ bool PluginInstance::PrintRasterOutput(PP_Resource print_output,
PPB_ImageData_Impl* image =
static_cast<PPB_ImageData_Impl*>(enter.object());
- // TODO(brettw) this should not require the image to be mapped. It should
- // instead map on demand. The DCHECK here is to remind you if you see the
- // assert fire, fix the bug rather than mapping the data.
- DCHECK(image->is_mapped());
- if (!image->is_mapped())
+ if (!image->Map())
return false;
const SkBitmap* bitmap = image->GetMappedBitmap();
« no previous file with comments | « ppapi/shared_impl/resource_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698