Simplify the incognito NTP.

Simplify the incognito NTP.

BUG=70664
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133893

[Mike West, 2012-02-27 13:16:33]

Hey Glen!

Here's a quick CL to implement the text currently proposed in
http://crbug.com/70664 The single change is the addition of "all" to the note
about closing incognito windows, as we added that in a release or three ago in
response to some user questions. I believe we should keep it.

I'd also make one last request to include secret agents. I like them, but that's
up to you. :)

nepper, jeffreyc: FYI

Thanks!

-Mike

[Mike West, 2012-03-02 17:24:47]

Friendly ping. :)

On 2012/02/27 13:16:33, Mike West (chromium) wrote:
> Hey Glen!
> 
> Here's a quick CL to implement the text currently proposed in
> http://crbug.com/70664 The single change is the addition of "all" to the note
> about closing incognito windows, as we added that in a release or three ago in
> response to some user questions. I believe we should keep it.
> 
> I'd also make one last request to include secret agents. I like them, but
that's
> up to you. :)
> 
> nepper, jeffreyc: FYI
> 
> Thanks!
> 
> -Mike

[Mike West, 2012-03-08 06:28:17]

Friendlier ping. :)

On 2012/03/02 17:24:47, Mike West (chromium) wrote:
> Friendly ping. :)
> 
> On 2012/02/27 13:16:33, Mike West (chromium) wrote:
> > Hey Glen!
> > 
> > Here's a quick CL to implement the text currently proposed in
> > http://crbug.com/70664 The single change is the addition of "all" to the
note
> > about closing incognito windows, as we added that in a release or three ago
in
> > response to some user questions. I believe we should keep it.
> > 
> > I'd also make one last request to include secret agents. I like them, but
> that's
> > up to you. :)
> > 
> > nepper, jeffreyc: FYI
> > 
> > Thanks!
> > 
> > -Mike

[Glen Murphy, 2012-03-08 18:26:14]

Text and code changes LGTM. Can you send along a screenshot when you get a
chance?


On 2012/03/08 06:28:17, Mike West (chromium) wrote:
> Friendlier ping. :)
> 
> On 2012/03/02 17:24:47, Mike West (chromium) wrote:
> > Friendly ping. :)
> > 
> > On 2012/02/27 13:16:33, Mike West (chromium) wrote:
> > > Hey Glen!
> > > 
> > > Here's a quick CL to implement the text currently proposed in
> > > http://crbug.com/70664 The single change is the addition of "all" to the
> note
> > > about closing incognito windows, as we added that in a release or three
ago
> in
> > > response to some user questions. I believe we should keep it.
> > > 
> > > I'd also make one last request to include secret agents. I like them, but
> > that's
> > > up to you. :)
> > > 
> > > nepper, jeffreyc: FYI
> > > 
> > > Thanks!
> > > 
> > > -Mike

[Mike West, 2012-03-09 10:35:46]

On 2012/03/08 18:26:14, Glen Murphy wrote:
> Text and code changes LGTM. Can you send along a screenshot when you get a
> chance?

Certainly: http://folder/mkwst/mocks/issue-70664/

It looks like we'll need to take a look at Android's strings as well: they've
been unforked over the last few days. I'd also like to make sure we change the
label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It looks like at
least one of the Android strings will require some change to as-yet unforked
code.  Adding nyquist@ as a reviewer for those changes.

[Patrick Nepper, 2012-03-09 10:44:13]

Thanks, looks good to me.

I'd like to +1 Mike's comment to include a "spy" back in. I might have
missed the respective discussion, but don't we want to keep the
light-hearted tone that has become typical for Chrome? I thought this was
Glen's and Brian's position, too?

I'm not fixed on the spy, though - any anecdote that makes this window a
little less serious would be appreciated IMO.

Patrick


On Fri, Mar 9, 2012 at 11:35 AM, <mkwst@chromium.org> wrote:

> On 2012/03/08 18:26:14, Glen Murphy wrote:
>
>> Text and code changes LGTM. Can you send along a screenshot when you get a
>> chance?
>>
>
> Certainly:
http://folder/mkwst/mocks/**issue-70664/<http://folder/mkwst/mocks/issue-70664/>
>
> It looks like we'll need to take a look at Android's strings as well:
> they've
> been unforked over the last few days. I'd also like to make sure we change
> the
> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It looks
> like at
> least one of the Android strings will require some change to as-yet
> unforked
> code.  Adding nyquist@ as a reviewer for those changes.
>
>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>

[jeffreyc, 2012-03-09 18:34:25]

Glen's guidance in the bug was that the "people standing behind you"
comment captures enough of the tone we want. Also, I'm thinking that in the
modern security climate, maybe it's best not to joke about spies too much.


On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org> wrote:

> Thanks, looks good to me.
>
> I'd like to +1 Mike's comment to include a "spy" back in. I might have
> missed the respective discussion, but don't we want to keep the
> light-hearted tone that has become typical for Chrome? I thought this was
> Glen's and Brian's position, too?
>
> I'm not fixed on the spy, though - any anecdote that makes this window a
> little less serious would be appreciated IMO.
>
> Patrick
>
>
>
> On Fri, Mar 9, 2012 at 11:35 AM, <mkwst@chromium.org> wrote:
>
>> On 2012/03/08 18:26:14, Glen Murphy wrote:
>>
>>> Text and code changes LGTM. Can you send along a screenshot when you get
>>> a
>>> chance?
>>>
>>
>> Certainly:
http://folder/mkwst/mocks/**issue-70664/<http://folder/mkwst/mocks/issue-70664/>
>>
>> It looks like we'll need to take a look at Android's strings as well:
>> they've
>> been unforked over the last few days. I'd also like to make sure we
>> change the
>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It looks
>> like at
>> least one of the Android strings will require some change to as-yet
>> unforked
>> code.  Adding nyquist@ as a reviewer for those changes.
>>
>>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>>
>
>

[nyquist, 2012-03-09 18:35:25]

For me this looks like a good opportunity to create one short incognito story,
instead of having very different messages.

As of now we have IDS_NEW_TAB_OTR_MESSAGE for Android (possibly
IDS_NEW_TAB_OTR_MESSAGE_MOBILE).

Since this new shortened message seems very similar to the mobile version, any
chance it can use the text proposed in IDS_NEW_TAB_OTR_MESSAGE_MOBILE instead?
Except of course the word "computer" vs. "mobile device" and not including
extensions-message.

http://codereview.chromium.org/9455078/diff/10001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9455078/diff/10001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9059: +                 desc="Mobile: Used
when a person opens an incognito window">
We do not have windows in Android, only tabs. Suggestion:
Mobile: Used when a person opens an incognito tab

http://codereview.chromium.org/9455078/diff/10001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9070: +                 desc="Mobile: Used
when a person opens an incognito window">
Same as above; we do not have windows.

[jeffreyc, 2012-03-09 20:45:29]

Another idea - add a message at the bottom:

*"Have fun searching for those surprise gifts!"*

On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <jeffreyc@chromium.org> wrote:

> Glen's guidance in the bug was that the "people standing behind you"
> comment captures enough of the tone we want. Also, I'm thinking that in the
> modern security climate, maybe it's best not to joke about spies too much.
>
>
> On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org>wrote:
>
>> Thanks, looks good to me.
>>
>> I'd like to +1 Mike's comment to include a "spy" back in. I might have
>> missed the respective discussion, but don't we want to keep the
>> light-hearted tone that has become typical for Chrome? I thought this was
>> Glen's and Brian's position, too?
>>
>> I'm not fixed on the spy, though - any anecdote that makes this window a
>> little less serious would be appreciated IMO.
>>
>> Patrick
>>
>>
>>
>> On Fri, Mar 9, 2012 at 11:35 AM, <mkwst@chromium.org> wrote:
>>
>>> On 2012/03/08 18:26:14, Glen Murphy wrote:
>>>
>>>> Text and code changes LGTM. Can you send along a screenshot when you
>>>> get a
>>>> chance?
>>>>
>>>
>>> Certainly:
http://folder/mkwst/mocks/**issue-70664/<http://folder/mkwst/mocks/issue-70664/>
>>>
>>> It looks like we'll need to take a look at Android's strings as well:
>>> they've
>>> been unforked over the last few days. I'd also like to make sure we
>>> change the
>>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It looks
>>> like at
>>> least one of the Android strings will require some change to as-yet
>>> unforked
>>> code.  Adding nyquist@ as a reviewer for those changes.
>>>
>>>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>>>
>>
>>
>

[Mike West, 2012-03-12 10:50:51]

I'm happy to combine these messages together if you folks can give me some text
that everyone's happy with. :)

Glen, Jeff, how do you feel about just using Android's IDS_NEW_TAB_OTR_MESSAGE?

-Mike

On 2012/03/09 20:45:29, jeffreyc wrote:
> Another idea - add a message at the bottom:
> 
> *"Have fun searching for those surprise gifts!"*
> 
> On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <mailto:jeffreyc@chromium.org>
wrote:
> 
> > Glen's guidance in the bug was that the "people standing behind you"
> > comment captures enough of the tone we want. Also, I'm thinking that in the
> > modern security climate, maybe it's best not to joke about spies too much.
> >
> >
> > On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org>wrote:
> >
> >> Thanks, looks good to me.
> >>
> >> I'd like to +1 Mike's comment to include a "spy" back in. I might have
> >> missed the respective discussion, but don't we want to keep the
> >> light-hearted tone that has become typical for Chrome? I thought this was
> >> Glen's and Brian's position, too?
> >>
> >> I'm not fixed on the spy, though - any anecdote that makes this window a
> >> little less serious would be appreciated IMO.
> >>
> >> Patrick
> >>
> >>
> >>
> >> On Fri, Mar 9, 2012 at 11:35 AM, <mailto:mkwst@chromium.org> wrote:
> >>
> >>> On 2012/03/08 18:26:14, Glen Murphy wrote:
> >>>
> >>>> Text and code changes LGTM. Can you send along a screenshot when you
> >>>> get a
> >>>> chance?
> >>>>
> >>>
> >>> Certainly:
>
http://folder/mkwst/mocks/**issue-70664/%3Chttp://folder/mkwst/mocks/issue-70...>
> >>>
> >>> It looks like we'll need to take a look at Android's strings as well:
> >>> they've
> >>> been unforked over the last few days. I'd also like to make sure we
> >>> change the
> >>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It looks
> >>> like at
> >>> least one of the Android strings will require some change to as-yet
> >>> unforked
> >>> code.  Adding nyquist@ as a reviewer for those changes.
> >>>
> >>>
>
http://codereview.chromium.**org/9455078/%3Chttp://codereview.chromium.org/94...>
> >>>
> >>
> >>
> >

[jeffreyc, 2012-03-12 17:25:10]

What exactly is Android's IDS_NEW_TAB_OTR_MESSAGE?


On Mon, Mar 12, 2012 at 3:50 AM, <mkwst@chromium.org> wrote:

> I'm happy to combine these messages together if you folks can give me some
> text
> that everyone's happy with. :)
>
> Glen, Jeff, how do you feel about just using Android's
> IDS_NEW_TAB_OTR_MESSAGE?
>
> -Mike
>
>
> On 2012/03/09 20:45:29, jeffreyc wrote:
>
>> Another idea - add a message at the bottom:
>>
>
>  *"Have fun searching for those surprise gifts!"*
>>
>
>  On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <mailto:jeffreyc@chromium.org
>> >
>>
> wrote:
>
>  > Glen's guidance in the bug was that the "people standing behind you"
>> > comment captures enough of the tone we want. Also, I'm thinking that in
>> the
>> > modern security climate, maybe it's best not to joke about spies too
>> much.
>> >
>> >
>> > On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org
>> >wrote:
>> >
>> >> Thanks, looks good to me.
>> >>
>> >> I'd like to +1 Mike's comment to include a "spy" back in. I might have
>> >> missed the respective discussion, but don't we want to keep the
>> >> light-hearted tone that has become typical for Chrome? I thought this
>> was
>> >> Glen's and Brian's position, too?
>> >>
>> >> I'm not fixed on the spy, though - any anecdote that makes this window
>> a
>> >> little less serious would be appreciated IMO.
>> >>
>> >> Patrick
>> >>
>> >>
>> >>
>> >> On Fri, Mar 9, 2012 at 11:35 AM, <mailto:mkwst@chromium.org> wrote:
>> >>
>> >>> On 2012/03/08 18:26:14, Glen Murphy wrote:
>> >>>
>> >>>> Text and code changes LGTM. Can you send along a screenshot when you
>> >>>> get a
>> >>>> chance?
>> >>>>
>> >>>
>> >>> Certainly:
>>
>
> http://folder/mkwst/mocks/****issue-70664/%3Chttp://folder/**
>
mkwst/mocks/issue-70664/<http://folder/mkwst/mocks/**issue-70664/%3Chttp://folder/mkwst/mocks/issue-70664/>
> >
>
>  >>>
>> >>> It looks like we'll need to take a look at Android's strings as well:
>> >>> they've
>> >>> been unforked over the last few days. I'd also like to make sure we
>> >>> change the
>> >>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It
>> looks
>> >>> like at
>> >>> least one of the Android strings will require some change to as-yet
>> >>> unforked
>> >>> code.  Adding nyquist@ as a reviewer for those changes.
>> >>>
>> >>>
>>
>
> http://codereview.chromium.****org/9455078/%3Chttp://coderevi**
> ew.chromium.org/9455078/ <http://codereview.chromium.org/9455078/>>
>
>> >>>
>> >>
>> >>
>> >
>>
>
>
>
>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>

[nyquist_google.com, 2012-03-12 19:10:36]

The Android message looks like:

*####*
*You've gone incognito.*

Pages you view in this tab won't appear in your browser history or search
history, and they won't leave other traces, like cookies, on your mobile
device after you close *all* incognito tabs. Any files you download or
bookmarks you create will be preserved, however.

<link>Learn more</link> about incognito browsing.
###

Note the use of tabs vs. windows, which probably would have to be changed
for desktop.

On Mon, Mar 12, 2012 at 10:24 AM, Jeff Chang <jeffreyc@chromium.org> wrote:

> What exactly is Android's IDS_NEW_TAB_OTR_MESSAGE?
>
>
> On Mon, Mar 12, 2012 at 3:50 AM, <mkwst@chromium.org> wrote:
>
>> I'm happy to combine these messages together if you folks can give me
>> some text
>> that everyone's happy with. :)
>>
>> Glen, Jeff, how do you feel about just using Android's
>> IDS_NEW_TAB_OTR_MESSAGE?
>>
>> -Mike
>>
>>
>> On 2012/03/09 20:45:29, jeffreyc wrote:
>>
>>> Another idea - add a message at the bottom:
>>>
>>
>>  *"Have fun searching for those surprise gifts!"*
>>>
>>
>>  On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <mailto:
>>> jeffreyc@chromium.org>
>>>
>> wrote:
>>
>>  > Glen's guidance in the bug was that the "people standing behind you"
>>> > comment captures enough of the tone we want. Also, I'm thinking that
>>> in the
>>> > modern security climate, maybe it's best not to joke about spies too
>>> much.
>>> >
>>> >
>>> > On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org
>>> >wrote:
>>> >
>>> >> Thanks, looks good to me.
>>> >>
>>> >> I'd like to +1 Mike's comment to include a "spy" back in. I might have
>>> >> missed the respective discussion, but don't we want to keep the
>>> >> light-hearted tone that has become typical for Chrome? I thought this
>>> was
>>> >> Glen's and Brian's position, too?
>>> >>
>>> >> I'm not fixed on the spy, though - any anecdote that makes this
>>> window a
>>> >> little less serious would be appreciated IMO.
>>> >>
>>> >> Patrick
>>> >>
>>> >>
>>> >>
>>> >> On Fri, Mar 9, 2012 at 11:35 AM, <mailto:mkwst@chromium.org> wrote:
>>> >>
>>> >>> On 2012/03/08 18:26:14, Glen Murphy wrote:
>>> >>>
>>> >>>> Text and code changes LGTM. Can you send along a screenshot when you
>>> >>>> get a
>>> >>>> chance?
>>> >>>>
>>> >>>
>>> >>> Certainly:
>>>
>>
>> http://folder/mkwst/mocks/****issue-70664/%3Chttp://folder/**
>>
mkwst/mocks/issue-70664/<http://folder/mkwst/mocks/**issue-70664/%3Chttp://folder/mkwst/mocks/issue-70664/>
>> >
>>
>>  >>>
>>> >>> It looks like we'll need to take a look at Android's strings as well:
>>> >>> they've
>>> >>> been unforked over the last few days. I'd also like to make sure we
>>> >>> change the
>>> >>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It
>>> looks
>>> >>> like at
>>> >>> least one of the Android strings will require some change to as-yet
>>> >>> unforked
>>> >>> code.  Adding nyquist@ as a reviewer for those changes.
>>> >>>
>>> >>>
>>>
>>
>> http://codereview.chromium.****org/9455078/%3Chttp://coderevi**
>> ew.chromium.org/9455078/ <http://codereview.chromium.org/9455078/>>
>>
>>> >>>
>>> >>
>>> >>
>>> >
>>>
>>
>>
>>
>>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>>
>
>

[jeffreyc, 2012-03-12 19:47:43]

Hmm, not sure if that was a technical question (about which string
constant(s) to use), or a UX question. Sounds like you'd have to replace
"tab" with "window", and "mobile device" with "computer", anyway.

What is shown at http://folder/mkwst/mocks/issue-70664/ LGTM.

On Mon, Mar 12, 2012 at 12:10 PM, Tommy Nyquist <nyquist@google.com> wrote:

> The Android message looks like:
>
> *####*
> *You've gone incognito.*
>
> Pages you view in this tab won't appear in your browser history or search
> history, and they won't leave other traces, like cookies, on your mobile
> device after you close *all* incognito tabs. Any files you download or
> bookmarks you create will be preserved, however.
>
> <link>Learn more</link> about incognito browsing.
> ###
>
> Note the use of tabs vs. windows, which probably would have to be changed
> for desktop.
>
> On Mon, Mar 12, 2012 at 10:24 AM, Jeff Chang <jeffreyc@chromium.org>wrote:
>
>> What exactly is Android's IDS_NEW_TAB_OTR_MESSAGE?
>>
>>
>> On Mon, Mar 12, 2012 at 3:50 AM, <mkwst@chromium.org> wrote:
>>
>>> I'm happy to combine these messages together if you folks can give me
>>> some text
>>> that everyone's happy with. :)
>>>
>>> Glen, Jeff, how do you feel about just using Android's
>>> IDS_NEW_TAB_OTR_MESSAGE?
>>>
>>> -Mike
>>>
>>>
>>> On 2012/03/09 20:45:29, jeffreyc wrote:
>>>
>>>> Another idea - add a message at the bottom:
>>>>
>>>
>>>  *"Have fun searching for those surprise gifts!"*
>>>>
>>>
>>>  On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <mailto:
>>>> jeffreyc@chromium.org>
>>>>
>>> wrote:
>>>
>>>  > Glen's guidance in the bug was that the "people standing behind you"
>>>> > comment captures enough of the tone we want. Also, I'm thinking that
>>>> in the
>>>> > modern security climate, maybe it's best not to joke about spies too
>>>> much.
>>>> >
>>>> >
>>>> > On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper <nepper@chromium.org
>>>> >wrote:
>>>> >
>>>> >> Thanks, looks good to me.
>>>> >>
>>>> >> I'd like to +1 Mike's comment to include a "spy" back in. I might
>>>> have
>>>> >> missed the respective discussion, but don't we want to keep the
>>>> >> light-hearted tone that has become typical for Chrome? I thought
>>>> this was
>>>> >> Glen's and Brian's position, too?
>>>> >>
>>>> >> I'm not fixed on the spy, though - any anecdote that makes this
>>>> window a
>>>> >> little less serious would be appreciated IMO.
>>>> >>
>>>> >> Patrick
>>>> >>
>>>> >>
>>>> >>
>>>> >> On Fri, Mar 9, 2012 at 11:35 AM, <mailto:mkwst@chromium.org> wrote:
>>>> >>
>>>> >>> On 2012/03/08 18:26:14, Glen Murphy wrote:
>>>> >>>
>>>> >>>> Text and code changes LGTM. Can you send along a screenshot when
>>>> you
>>>> >>>> get a
>>>> >>>> chance?
>>>> >>>>
>>>> >>>
>>>> >>> Certainly:
>>>>
>>>
>>> http://folder/mkwst/mocks/****issue-70664/%3Chttp://folder/**
>>>
mkwst/mocks/issue-70664/<http://folder/mkwst/mocks/**issue-70664/%3Chttp://folder/mkwst/mocks/issue-70664/>
>>> >
>>>
>>>  >>>
>>>> >>> It looks like we'll need to take a look at Android's strings as
>>>> well:
>>>> >>> they've
>>>> >>> been unforked over the last few days. I'd also like to make sure we
>>>> >>> change the
>>>> >>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It
>>>> looks
>>>> >>> like at
>>>> >>> least one of the Android strings will require some change to as-yet
>>>> >>> unforked
>>>> >>> code.  Adding nyquist@ as a reviewer for those changes.
>>>> >>>
>>>> >>>
>>>>
>>>
>>> http://codereview.chromium.****org/9455078/%3Chttp://coderevi**
>>> ew.chromium.org/9455078/ <http://codereview.chromium.org/9455078/>>
>>>
>>>> >>>
>>>> >>
>>>> >>
>>>> >
>>>>
>>>
>>>
>>>
>>>
http://codereview.chromium.**org/9455078/<http://codereview.chromium.org/9455...
>>>
>>
>>
>

[Patrick Nepper, 2012-04-24 11:19:25]

Given the differences in form factors for Chrome mobile vs. Chrome desktop, I'm
comfortable with having a minor difference between the mobile version and the
desktop version (the desktop version has an additional statement on limitations
a.k.a. "people standing behind you" and a phrase on extensions).

Let's land it this way.

LGTM

Thanks!

If there is need for further unification we can do so in another iteration.
On 2012/03/12 19:47:43, jeffreyc wrote:
> Hmm, not sure if that was a technical question (about which string
> constant(s) to use), or a UX question. Sounds like you'd have to replace
> "tab" with "window", and "mobile device" with "computer", anyway.
> 
> What is shown at http://folder/mkwst/mocks/issue-70664/ LGTM.
> 
> On Mon, Mar 12, 2012 at 12:10 PM, Tommy Nyquist <mailto:nyquist@google.com>
wrote:
> 
> > The Android message looks like:
> >
> > *####*
> > *You've gone incognito.*
> >
> > Pages you view in this tab won't appear in your browser history or search
> > history, and they won't leave other traces, like cookies, on your mobile
> > device after you close *all* incognito tabs. Any files you download or
> > bookmarks you create will be preserved, however.
> >
> > <link>Learn more</link> about incognito browsing.
> > ###
> >
> > Note the use of tabs vs. windows, which probably would have to be changed
> > for desktop.
> >
> > On Mon, Mar 12, 2012 at 10:24 AM, Jeff Chang <jeffreyc@chromium.org>wrote:
> >
> >> What exactly is Android's IDS_NEW_TAB_OTR_MESSAGE?
> >>
> >>
> >> On Mon, Mar 12, 2012 at 3:50 AM, <mailto:mkwst@chromium.org> wrote:
> >>
> >>> I'm happy to combine these messages together if you folks can give me
> >>> some text
> >>> that everyone's happy with. :)
> >>>
> >>> Glen, Jeff, how do you feel about just using Android's
> >>> IDS_NEW_TAB_OTR_MESSAGE?
> >>>
> >>> -Mike
> >>>
> >>>
> >>> On 2012/03/09 20:45:29, jeffreyc wrote:
> >>>
> >>>> Another idea - add a message at the bottom:
> >>>>
> >>>
> >>>  *"Have fun searching for those surprise gifts!"*
> >>>>
> >>>
> >>>  On Fri, Mar 9, 2012 at 10:34 AM, Jeff Chang <mailto:
> >>>> mailto:jeffreyc@chromium.org>
> >>>>
> >>> wrote:
> >>>
> >>>  > Glen's guidance in the bug was that the "people standing behind you"
> >>>> > comment captures enough of the tone we want. Also, I'm thinking that
> >>>> in the
> >>>> > modern security climate, maybe it's best not to joke about spies too
> >>>> much.
> >>>> >
> >>>> >
> >>>> > On Fri, Mar 9, 2012 at 2:44 AM, Patrick Nepper
<mailto:nepper@chromium.org
> >>>> >wrote:
> >>>> >
> >>>> >> Thanks, looks good to me.
> >>>> >>
> >>>> >> I'd like to +1 Mike's comment to include a "spy" back in. I might
> >>>> have
> >>>> >> missed the respective discussion, but don't we want to keep the
> >>>> >> light-hearted tone that has become typical for Chrome? I thought
> >>>> this was
> >>>> >> Glen's and Brian's position, too?
> >>>> >>
> >>>> >> I'm not fixed on the spy, though - any anecdote that makes this
> >>>> window a
> >>>> >> little less serious would be appreciated IMO.
> >>>> >>
> >>>> >> Patrick
> >>>> >>
> >>>> >>
> >>>> >>
> >>>> >> On Fri, Mar 9, 2012 at 11:35 AM, <mailto:mkwst@chromium.org> wrote:
> >>>> >>
> >>>> >>> On 2012/03/08 18:26:14, Glen Murphy wrote:
> >>>> >>>
> >>>> >>>> Text and code changes LGTM. Can you send along a screenshot when
> >>>> you
> >>>> >>>> get a
> >>>> >>>> chance?
> >>>> >>>>
> >>>> >>>
> >>>> >>> Certainly:
> >>>>
> >>>
> >>> http://folder/mkwst/mocks/****issue-70664/%253Chttp://folder/**
> >>>
>
mkwst/mocks/issue-70664/<http://folder/mkwst/mocks/**issue-70664/%3Chttp://folder/mkwst/mocks/issue-70664/>
> >>> >
> >>>
> >>>  >>>
> >>>> >>> It looks like we'll need to take a look at Android's strings as
> >>>> well:
> >>>> >>> they've
> >>>> >>> been unforked over the last few days. I'd also like to make sure we
> >>>> >>> change the
> >>>> >>> label names from `..._OTR_MESSAGE` to `..._INCOGNITO_MESSAGE`. It
> >>>> looks
> >>>> >>> like at
> >>>> >>> least one of the Android strings will require some change to as-yet
> >>>> >>> unforked
> >>>> >>> code.  Adding nyquist@ as a reviewer for those changes.
> >>>> >>>
> >>>> >>>
> >>>>
> >>>
> >>> http://codereview.chromium.****org/9455078/%253Chttp://coderevi**
> >>> ew.chromium.org/9455078/ <http://codereview.chromium.org/9455078/>>
> >>>
> >>>> >>>
> >>>> >>
> >>>> >>
> >>>> >
> >>>>
> >>>
> >>>
> >>>
> >>>
>
http://codereview.chromium.**org/9455078/%3Chttp://codereview.chromium.org/94...>
> >>>
> >>
> >>
> >

[Mike West, 2012-04-24 12:30:03]

Ok. I'm running with it as-is, then.

Adding estade@ for OWNERS review. Would you mind taking a look, Evan?

Thanks!

-mike

[Evan Stade, 2012-04-24 20:42:11]

lgtm

http://codereview.chromium.org/9455078/diff/24001/chrome/browser/resources/in...
File chrome/browser/resources/incognito_tab.css (right):

http://codereview.chromium.org/9455078/diff/24001/chrome/browser/resources/in...
chrome/browser/resources/incognito_tab.css:31: box-shadow: 0 3px 5px
rgba(0,0,0,0.25);
spaces

[commit-bot: I haz the power, 2012-04-25 09:32:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/9455078/30001

[commit-bot: I haz the power, 2012-04-25 11:32:32]

Change committed as 133893