Issue 9453020: Fix handling of unresolved names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9453020: Fix handling of unresolved names (Closed)

Created:
8 years, 10 months ago by hausner

Modified:
8 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix handling of unresolved names Fixes issue 1805 (http://code.google.com/p/dart/issues/detail?id=1805) The VM didn't turn unresolved identifiers into instance getter calls in all cases. Refactored the code that handles primary expressions. Committed: https://code.google.com/p/dart/source/detail?r=4550

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -64 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	7 chunks	+90 lines, -59 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/9453020/diff/4001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/9453020/diff/4001/runtime/vm/parser.cc#newcode7530 runtime/vm/parser.cc:7530: *(qual_ident.ident), token_index_); Strange indentation. But why not just ...

8 years, 10 months ago (2012-02-23 19:11:44 UTC) #2

hausner

8 years, 10 months ago (2012-02-23 19:43:18 UTC) #3

Thanks!

http://codereview.chromium.org/9453020/diff/4001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/9453020/diff/4001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:7530: *(qual_ident.ident), token_index_);
On 2012/02/23 19:11:44, regis wrote:
> Strange indentation.
> But why not just one statement:
> const TypeParameter& type_param =
> TypeParameter::ZoneHandle(scope_class.LookupTypeParameter(...

Found it more readable with two statements due to the long expression. Changed
to one statement.

Expand Messages | Collapse Messages