Issue 9447015: MIPS: Fix for cctest test-api/ExternalArrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9447015: MIPS: Fix for cctest test-api/ExternalArrays. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 9 months ago

Reviewers:
kisg, Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Fix for cctest test-api/ExternalArrays. On MIPS a different constant value is used by the FPU when converting undefined values. BUG= TEST=

Patch Set 1 #

Patch Set 2 : rebased on r10833. #

Patch Set 3 : rebased on r10858. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	test/cctest/test-api.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danno

On 2012/02/28 14:31:38, kalmard wrote: > rebased on r10858. The existing check is not for ...

8 years, 9 months ago (2012-02-29 13:23:58 UTC) #4

kalmard

8 years, 9 months ago (2012-03-01 11:21:08 UTC) #5

On 2012/02/29 13:23:58, danno wrote:
> On 2012/02/28 14:31:38, kalmard wrote:
> > rebased on r10858.
> The existing check is not for invalid, it is for whatever value undefined
> produces, which is NaN. Apparently casting NaN to int differs on MIPS, ARM and
> Intel. 
> 
> I think that the need for this CL disappears after r10867, which changes the
> test to explicitly test for the casted NaN, but please verify that it works on
> MIPS.

Thanks for the review. r10867 fixes the test indeed. Closing.

Expand Messages | Collapse Messages