Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: test/cctest/test-api.cc

Issue 9447015: MIPS: Fix for cctest test-api/ExternalArrays. (Closed)
Patch Set: rebased on r10858. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index a7e45d18ef5a69c3e823c3705b6f4e9acaefb8f0..78f4703464f0b6a3a42dcdb687d3d77582506775 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -12734,6 +12734,13 @@ static int ExternalArrayElementSize(v8::ExternalArrayType array_type) {
}
+#if defined(V8_TARGET_ARCH_MIPS) && !defined(USE_SIMULATOR)
+static const int kUndefinedResult = static_cast<int>(0x80000000 - 1);
+#else
+static const int kUndefinedResult = static_cast<int>(0x80000000);
+#endif
+
+
template <class ExternalArrayClass, class ElementType>
static void ExternalArrayTestHelper(v8::ExternalArrayType array_type,
int64_t low,
@@ -12910,7 +12917,7 @@ static void ExternalArrayTestHelper(v8::ExternalArrayType array_type,
if (array_type == v8::kExternalDoubleArray ||
array_type == v8::kExternalFloatArray) {
CHECK_EQ(
- static_cast<int>(0x80000000),
+ static_cast<int>(kUndefinedResult),
static_cast<int>(jsobj->GetElement(7)->ToObjectChecked()->Number()));
} else {
CHECK_EQ(0, static_cast<int>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698