Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 9442002: Add a hard limit for Flash JIT pages (Closed)

Created:
8 years, 10 months ago by jschuh
Modified:
8 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add a hard limit for Flash JIT pages This includes a unique exception signature that I will monitor for crashes: http://crash/search?query=crash_reason%3A%22EXCEPTION_ACCESS_VIOLATION_WRITE%22+crash_address%3A%222880249322%22+product%3A%22Chrome%22

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 4 chunks +10 lines, -7 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
jschuh
Adding a hard limit. I'll monitor canary and if crashes are high I'll scale it ...
8 years, 10 months ago (2012-02-22 23:42:14 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm http://codereview.chromium.org/9442002/diff/1/webkit/plugins/npapi/webplugin_delegate_impl_win.cc File webkit/plugins/npapi/webplugin_delegate_impl_win.cc (right): http://codereview.chromium.org/9442002/diff/1/webkit/plugins/npapi/webplugin_delegate_impl_win.cc#newcode174 webkit/plugins/npapi/webplugin_delegate_impl_win.cc:174: 2, parameters); instead of 2 use arraysize of ...
8 years, 10 months ago (2012-02-23 01:06:10 UTC) #2
cpu_(ooo_6.6-7.5)
reminder to remove the VirtualAlloc patch
8 years, 10 months ago (2012-02-23 01:18:01 UTC) #3
ananta
LGTM
8 years, 10 months ago (2012-02-23 02:18:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/9442002/1
8 years, 10 months ago (2012-02-23 03:13:11 UTC) #5
commit-bot: I haz the power
Try job failure for 9442002-1 (retry) on win_rel for steps "browser_tests, ui_tests". It's a second ...
8 years, 10 months ago (2012-02-23 06:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/9442002/1
8 years, 10 months ago (2012-02-23 06:39:51 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 09:42:33 UTC) #8
Change committed as 123205

Powered by Google App Engine
This is Rietveld 408576698