Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 9430050: Remove usage of a deprecated TestServer constructor. (Closed)

Created:
8 years, 10 months ago by erikwright (departed)
Modified:
8 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove usage of a deprecated TestServer constructor. Hostname must now be explicitly specified (previously default was 127.0.0.1). See the following CL for further details: http://codereview.chromium.org/9369029/ A follow-up CL will remove the deprecated constructor: http://codereview.chromium.org/9431002/ BUG=114369 TEST=everything still compiles and passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123486

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disentangle test refactoring from TestServer refactoring. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -31 lines) Patch
M chrome/browser/net/connection_tester_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/ftp_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/load_timing_observer_uitest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/network_stats_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/net/url_fetcher_impl_unittest.cc View 15 chunks +45 lines, -15 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 8 chunks +24 lines, -8 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikwright (departed)
8 years, 10 months ago (2012-02-22 16:00:11 UTC) #1
erikwright (departed)
Ping :) (Mostly boiler-plate, though I gave in to an urge to remove duplicate code ...
8 years, 10 months ago (2012-02-23 19:06:30 UTC) #2
eroman
Was OOO yesterday. Looking now...
8 years, 10 months ago (2012-02-23 20:47:11 UTC) #3
eroman
lgtm http://codereview.chromium.org/9430050/diff/1/chrome/browser/net/network_stats_unittest.cc File chrome/browser/net/network_stats_unittest.cc (right): http://codereview.chromium.org/9430050/diff/1/chrome/browser/net/network_stats_unittest.cc#newcode17 chrome/browser/net/network_stats_unittest.cc:17: template <typename T> class NetworkStatsTest : public PlatformTest ...
8 years, 10 months ago (2012-02-23 21:06:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9430050/9002
8 years, 10 months ago (2012-02-24 14:35:09 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-24 16:16:22 UTC) #6
Change committed as 123486

Powered by Google App Engine
This is Rietveld 408576698