Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 9430050: Remove usage of a deprecated TestServer constructor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disentangle test refactoring from TestServer refactoring. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index babe2434051fcc3cb3f087d0cff4e63f0cdc7d5d..caeaf71cbc6df57b4297df21e05f15b971668819 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -1211,8 +1211,9 @@ TEST_F(URLRequestTestHTTP, GetZippedTest) {
TEST_F(URLRequestTestHTTP, DISABLED_HTTPSToHTTPRedirectNoRefererTest) {
ASSERT_TRUE(test_server_.Start());
- TestServer https_test_server(
- TestServer::TYPE_HTTPS, FilePath(FILE_PATH_LITERAL("net/data/ssl")));
+ TestServer https_test_server(TestServer::TYPE_HTTPS,
+ TestServer::kLocalhost,
+ FilePath(FILE_PATH_LITERAL("net/data/ssl")));
ASSERT_TRUE(https_test_server.Start());
// An https server is sent a request with an https referer,
@@ -1274,6 +1275,7 @@ class HTTPSRequestTest : public testing::Test {
// (see bug 102991).
TEST_F(HTTPSRequestTest, DISABLED_HTTPSGetTest) {
TestServer test_server(TestServer::TYPE_HTTPS,
+ TestServer::kLocalhost,
FilePath(FILE_PATH_LITERAL("net/data/ssl")));
ASSERT_TRUE(test_server.Start());
@@ -3646,7 +3648,8 @@ TEST_F(URLRequestTest, RequestCompletionForEmptyResponse) {
class URLRequestTestFTP : public URLRequestTest {
public:
- URLRequestTestFTP() : test_server_(TestServer::TYPE_FTP, FilePath()) {
+ URLRequestTestFTP()
+ : test_server_(TestServer::TYPE_FTP, TestServer::kLocalhost, FilePath()) {
}
protected:
« no previous file with comments | « net/socket/ssl_client_socket_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698