Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9428056: ash: Create new containers for PowerButtonController. (Closed)

Created:
8 years, 10 months ago by Daniel Erat
Modified:
8 years, 10 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, alicet1
Visibility:
Public.

Description

ash: Create new containers for PowerButtonController. This nests ash's existing containers inside of three new higher-level containers-of-containers. The new higher-level containers can be animated by PowerButtonController without messing up transformations that have already been applied to the lower-level containers. BUG=114953 TEST=manual: locked and unlocked screen in compact mode with multiple browser windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123288

Patch Set 1 #

Patch Set 2 : update PowerButtonController #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -305 lines) Patch
M ash/shell.cc View 1 3 chunks +60 lines, -62 lines 0 comments Download
M ash/shell_window_ids.h View 1 chunk +30 lines, -14 lines 0 comments Download
M ash/wm/power_button_controller.h View 1 5 chunks +0 lines, -18 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 8 chunks +91 lines, -146 lines 1 comment Download
M ash/wm/power_button_controller_unittest.cc View 1 2 chunks +0 lines, -64 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
http://codereview.chromium.org/9428056/diff/2001/ash/wm/power_button_controller.cc File ash/wm/power_button_controller.cc (right): http://codereview.chromium.org/9428056/diff/2001/ash/wm/power_button_controller.cc#newcode160 ash/wm/power_button_controller.cc:160: void GetContainers(PowerButtonController::ContainerGroup group, Most of the changes to this ...
8 years, 10 months ago (2012-02-23 02:13:16 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 10 months ago (2012-02-23 17:06:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9428056/2001
8 years, 10 months ago (2012-02-23 17:18:11 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 19:06:15 UTC) #4
Change committed as 123288

Powered by Google App Engine
This is Rietveld 408576698