Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/background/background_application_list_model.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_application_list_model.cc
diff --git a/chrome/browser/background/background_application_list_model.cc b/chrome/browser/background/background_application_list_model.cc
index d7d47403f30a05c6d3bd8974534d21a0ee856f41..b72692885b3fd92816696f0e6a94231b2a515ed5 100644
--- a/chrome/browser/background/background_application_list_model.cc
+++ b/chrome/browser/background/background_application_list_model.cc
@@ -22,6 +22,7 @@
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
#include "ui/base/l10n/l10n_util_collator.h"
+#include "ui/gfx/image/image.h"
class ExtensionNameComparator {
public:
@@ -54,9 +55,9 @@ class BackgroundApplicationListModel::Application
virtual ~Application();
// Invoked when a request icon is available.
- virtual void OnImageLoaded(SkBitmap* image,
- const ExtensionResource& resource,
- int index);
+ virtual void OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
+ int index) OVERRIDE;
// Uses the FILE thread to request this extension's icon, sized
// appropriately.
@@ -128,12 +129,12 @@ BackgroundApplicationListModel::Application::Application(
}
void BackgroundApplicationListModel::Application::OnImageLoaded(
- SkBitmap* image,
- const ExtensionResource& resource,
+ const gfx::Image* image,
+ const std::string& extension_id,
int index) {
if (!image)
return;
- icon_.reset(new SkBitmap(*image));
+ icon_.reset(new SkBitmap(*image->ToSkBitmap()));
model_->SendApplicationDataChangedNotifications(extension_);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/app_shortcut_manager.h » ('j') | chrome/browser/extensions/app_shortcut_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698