Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/background/background_application_list_model.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/background/background_application_list_model.h" 5 #include "chrome/browser/background/background_application_list_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/background/background_mode_manager.h" 13 #include "chrome/browser/background/background_mode_manager.h"
14 #include "chrome/browser/browser_process.h" 14 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/extensions/extension_prefs.h" 15 #include "chrome/browser/extensions/extension_prefs.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/image_loading_tracker.h" 17 #include "chrome/browser/extensions/image_loading_tracker.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/common/chrome_notification_types.h" 19 #include "chrome/common/chrome_notification_types.h"
20 #include "chrome/common/extensions/extension.h" 20 #include "chrome/common/extensions/extension.h"
21 #include "chrome/common/extensions/extension_resource.h" 21 #include "chrome/common/extensions/extension_resource.h"
22 #include "content/public/browser/notification_details.h" 22 #include "content/public/browser/notification_details.h"
23 #include "content/public/browser/notification_source.h" 23 #include "content/public/browser/notification_source.h"
24 #include "ui/base/l10n/l10n_util_collator.h" 24 #include "ui/base/l10n/l10n_util_collator.h"
25 #include "ui/gfx/image/image.h"
25 26
26 class ExtensionNameComparator { 27 class ExtensionNameComparator {
27 public: 28 public:
28 explicit ExtensionNameComparator(icu::Collator* collator); 29 explicit ExtensionNameComparator(icu::Collator* collator);
29 bool operator()(const Extension* x, const Extension* y); 30 bool operator()(const Extension* x, const Extension* y);
30 31
31 private: 32 private:
32 icu::Collator* collator_; 33 icu::Collator* collator_;
33 }; 34 };
34 35
(...skipping 12 matching lines...) Expand all
47 // BackgroundApplicationListModel class. 48 // BackgroundApplicationListModel class.
48 class BackgroundApplicationListModel::Application 49 class BackgroundApplicationListModel::Application
49 : public ImageLoadingTracker::Observer { 50 : public ImageLoadingTracker::Observer {
50 public: 51 public:
51 Application(BackgroundApplicationListModel* model, 52 Application(BackgroundApplicationListModel* model,
52 const Extension* an_extension); 53 const Extension* an_extension);
53 54
54 virtual ~Application(); 55 virtual ~Application();
55 56
56 // Invoked when a request icon is available. 57 // Invoked when a request icon is available.
57 virtual void OnImageLoaded(SkBitmap* image, 58 virtual void OnImageLoaded(const gfx::Image* image,
58 const ExtensionResource& resource, 59 const std::string& extension_id,
59 int index); 60 int index) OVERRIDE;
60 61
61 // Uses the FILE thread to request this extension's icon, sized 62 // Uses the FILE thread to request this extension's icon, sized
62 // appropriately. 63 // appropriately.
63 void RequestIcon(Extension::Icons size); 64 void RequestIcon(Extension::Icons size);
64 65
65 const Extension* extension_; 66 const Extension* extension_;
66 scoped_ptr<SkBitmap> icon_; 67 scoped_ptr<SkBitmap> icon_;
67 BackgroundApplicationListModel* model_; 68 BackgroundApplicationListModel* model_;
68 ImageLoadingTracker tracker_; 69 ImageLoadingTracker tracker_;
69 }; 70 };
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 BackgroundApplicationListModel::Application::Application( 122 BackgroundApplicationListModel::Application::Application(
122 BackgroundApplicationListModel* model, 123 BackgroundApplicationListModel* model,
123 const Extension* extension) 124 const Extension* extension)
124 : extension_(extension), 125 : extension_(extension),
125 icon_(NULL), 126 icon_(NULL),
126 model_(model), 127 model_(model),
127 ALLOW_THIS_IN_INITIALIZER_LIST(tracker_(this)) { 128 ALLOW_THIS_IN_INITIALIZER_LIST(tracker_(this)) {
128 } 129 }
129 130
130 void BackgroundApplicationListModel::Application::OnImageLoaded( 131 void BackgroundApplicationListModel::Application::OnImageLoaded(
131 SkBitmap* image, 132 const gfx::Image* image,
132 const ExtensionResource& resource, 133 const std::string& extension_id,
133 int index) { 134 int index) {
134 if (!image) 135 if (!image)
135 return; 136 return;
136 icon_.reset(new SkBitmap(*image)); 137 icon_.reset(new SkBitmap(*image->ToSkBitmap()));
137 model_->SendApplicationDataChangedNotifications(extension_); 138 model_->SendApplicationDataChangedNotifications(extension_);
138 } 139 }
139 140
140 void BackgroundApplicationListModel::Application::RequestIcon( 141 void BackgroundApplicationListModel::Application::RequestIcon(
141 Extension::Icons size) { 142 Extension::Icons size) {
142 ExtensionResource resource = extension_->GetIconResource( 143 ExtensionResource resource = extension_->GetIconResource(
143 size, ExtensionIconSet::MATCH_BIGGER); 144 size, ExtensionIconSet::MATCH_BIGGER);
144 tracker_.LoadImage(extension_, resource, gfx::Size(size, size), 145 tracker_.LoadImage(extension_, resource, gfx::Size(size, size),
145 ImageLoadingTracker::CACHE); 146 ImageLoadingTracker::CACHE);
146 } 147 }
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 (*old_cursor)->name() == (*new_cursor)->name() && 350 (*old_cursor)->name() == (*new_cursor)->name() &&
350 (*old_cursor)->id() == (*new_cursor)->id()) { 351 (*old_cursor)->id() == (*new_cursor)->id()) {
351 ++old_cursor; 352 ++old_cursor;
352 ++new_cursor; 353 ++new_cursor;
353 } 354 }
354 if (old_cursor != extensions_.end() || new_cursor != extensions.end()) { 355 if (old_cursor != extensions_.end() || new_cursor != extensions.end()) {
355 extensions_ = extensions; 356 extensions_ = extensions;
356 FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged(profile_)); 357 FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged(profile_));
357 } 358 }
358 } 359 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/app_shortcut_manager.h » ('j') | chrome/browser/extensions/app_shortcut_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698