Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Unified Diff: chrome/browser/extensions/extension_window_controller.h

Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_window_controller.h
diff --git a/chrome/browser/extensions/extension_window_controller.h b/chrome/browser/extensions/extension_window_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..208bdc56d783dbba8667a94adc64b5e66a536488
--- /dev/null
+++ b/chrome/browser/extensions/extension_window_controller.h
@@ -0,0 +1,72 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WINDOW_CONTROLLER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_WINDOW_CONTROLLER_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+
+class BaseWindow;
+class GURL;
+class Profile;
+class SessionID;
+
+namespace base {
+class DictionaryValue;
+}
+
+namespace gfx {
+class Rect;
+}
+
+// This API needs to be implemented by any window that might be accessed
+// through chrome.windows or chrome.tabs (e.g. browser windows and panels).
+class ExtensionWindowController {
+ public:
+ enum Reason {
+ REASON_NONE,
+ REASON_TAB_STRIP_NOT_EDITABLE,
+ };
+
+ ExtensionWindowController(BaseWindow* window, Profile* profile);
+ virtual ~ExtensionWindowController();
+
+ BaseWindow* window() const { return window_; }
sky 2012/02/24 04:38:24 nit: since you're returning a non-const value, thi
stevenjb 2012/02/24 19:25:06 I copied the pattern from browser.h. Since this do
+
+ // Returns true if the window matches the profile.
+ virtual bool MatchesProfile(Profile* profile, bool allow_incognito) const;
sky 2012/02/24 04:38:24 Does this need to be virtual?
stevenjb 2012/02/24 19:25:06 It does not any more, thanks. Done.
+
+ // Return a session id uniquely identifying the window.
+ virtual const SessionID& GetSessionId() const = 0;
+
+ // Populates a dictionary for the Window object.
+ virtual base::DictionaryValue* CreateWindowValue() const = 0;
+
+ // Populates a dictionary for the Window object, including a list of tabs.
+ virtual base::DictionaryValue* CreateWindowValueWithTabs() const = 0;
+
+ // Returns false if the window is in a state where closing the window is not
+ // permitted and sets |reason| if not NULL.
+ virtual bool CanClose(Reason* reason) const = 0;
+
+ // Set the window's fullscreen state. |extension_url| provides the url
+ // associated with the extension (used by FullscreenController).
+ virtual void SetFullscreenMode(bool is_fullscreen,
+ const GURL& extension_url) const = 0;
+
+ protected:
+ // Helper function to set bounds properties.
+ void SetWindowValueBounds(const gfx::Rect& bounds,
+ base::DictionaryValue* result) const;
+
+ private:
+ BaseWindow* window_;
+ Profile* profile_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionWindowController);
+};
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_WINDOW_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698