chrome/browser/extensions/extension_tabs_test.cc - Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_test.cc

Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/browser_extension_window_controller.cc ('K') | « chrome/browser/extensions/extension_tabs_module.cc ('k') | chrome/browser/extensions/extension_window_controller.h » ('j') | chrome/browser/extensions/extension_window_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_test.cc

diff --git a/chrome/browser/extensions/extension_tabs_test.cc b/chrome/browser/extensions/extension_tabs_test.cc

index 1578b7aa494d0d837500098c1646a7c471b1c250..397cbc09fa649c9cc8d058939e2c896f541083e6 100644

--- a/chrome/browser/extensions/extension_tabs_test.cc

+++ b/chrome/browser/extensions/extension_tabs_test.cc

@@ -386,9 +386,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest,

IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, InvalidUpdateWindowState) {

int window_id = ExtensionTabUtil::GetWindowId(browser());

-#if !defined(USE_AURA)

- // Disabled for now (crbug.com/105173) because window minimization is not

- // supported on Aura yet (crbug.com/104571).

static const char kArgsMinimizedWithFocus[] =

"[%u, {\"state\": \"minimized\", \"focused\": true}]";

EXPECT_TRUE(MatchPattern(

@@ -397,7 +394,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, InvalidUpdateWindowState) {

base::StringPrintf(kArgsMinimizedWithFocus, window_id),

browser()),

keys::kInvalidWindowStateError));

-#endif

static const char kArgsMaximizedWithoutFocus[] =

"[%u, {\"state\": \"maximized\", \"focused\": false}]";

@@ -408,9 +404,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, InvalidUpdateWindowState) {

browser()),

keys::kInvalidWindowStateError));

-#if !defined(USE_AURA)

- // Disabled for now (crbug.com/105173) because window minimization is not

- // supported on Aura yet (crbug.com/104571).

static const char kArgsMinimizedWithBounds[] =

"[%u, {\"state\": \"minimized\", \"width\": 500}]";

EXPECT_TRUE(MatchPattern(

@@ -419,7 +412,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, InvalidUpdateWindowState) {

base::StringPrintf(kArgsMinimizedWithBounds, window_id),

browser()),

keys::kInvalidWindowStateError));

-#endif

static const char kArgsMaximizedWithBounds[] =

"[%u, {\"state\": \"maximized\", \"width\": 500}]";