Test file errors in downloads.

content/browser/download/download_file_manager.h

Index: content/browser/download/download_file_manager.h
diff --git a/content/browser/download/download_file_manager.h b/content/browser/download/download_file_manager.h
index b5f1654c4a74bf5323f64988d9fc932bb992fe76..313c69eae5957279a3214b9c0661b2c88f8a3962 100644
--- a/content/browser/download/download_file_manager.h
+++ b/content/browser/download/download_file_manager.h
@@ -144,6 +144,11 @@ class CONTENT_EXPORT DownloadFileManager
     return downloads_.size();
   }
 
+  // This is only for unit tests.

[cbentzel, 2012/02/28 14:51:41]

Comment doesn't totally seem required given the ForTesting response, but I'd
have Randy+John provide judgement on that instead of me.

[Randy Smith (Not in Mondays), 2012/02/28 22:06:13]

Agreed with Chris.

(Personal opinion is that we don't need John's opinion on the change to DFM
since it isn't in content/public, but I have no objections to roping him in if
either of you feel like it would be useful, and I would like him to at least
look at the code in content/test.)

[ahendrickson, 2012/03/01 09:17:32]

Removed comment.

[ahendrickson, 2012/03/01 09:17:32]

Done.

+  void SetFileFactoryForTesting(DownloadFileFactory* file_factory) {

[cbentzel, 2012/02/28 14:51:41]

This should pass in a scoped_ptr argument so transfer of ownership is obvious.

[ahendrickson, 2012/03/01 09:17:32]

Done.

+    download_file_factory_.reset(file_factory);
+  }
+
  private:
   friend class base::RefCountedThreadSafe<DownloadFileManager>;
   friend class DownloadFileManagerTest;