Test file errors in downloads.

content/browser/download/download_file_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadFileManager owns a set of DownloadFile objects, each of which
 // represent one in progress download and performs the disk IO for that
 // download. The DownloadFileManager itself is a singleton object owned by the
 // ResourceDispatcherHost.
 //
 // The DownloadFileManager uses the file_thread for performing file write
@@ skipping 126 matching lines @@
   void RenameCompletingDownloadFile(content::DownloadId id,
                                     const FilePath& full_path,
                                     bool overwrite_existing_file);
 
   // The number of downloads currently active on the DownloadFileManager.
   // Primarily for testing.
   int NumberOfActiveDownloads() const {
     return downloads_.size();
   }
 
+  // This is only for unit tests.

[cbentzel, 2012/02/28 14:51:41]

Comment doesn't totally seem required given the ForTesting response, but I'd
have Randy+John provide judgement on that instead of me.

[Randy Smith (Not in Mondays), 2012/02/28 22:06:13]

Agreed with Chris.

(Personal opinion is that we don't need John's opinion on the change to DFM
since it isn't in content/public, but I have no objections to roping him in if
either of you feel like it would be useful, and I would like him to at least
look at the code in content/test.)

[ahendrickson, 2012/03/01 09:17:32]

Removed comment.

[ahendrickson, 2012/03/01 09:17:32]

Done.

+  void SetFileFactoryForTesting(DownloadFileFactory* file_factory) {

[cbentzel, 2012/02/28 14:51:41]

This should pass in a scoped_ptr argument so transfer of ownership is obvious.

[ahendrickson, 2012/03/01 09:17:32]

Done.

+    download_file_factory_.reset(file_factory);
+  }
+
  private:
   friend class base::RefCountedThreadSafe<DownloadFileManager>;
   friend class DownloadFileManagerTest;
   friend class DownloadManagerTest;
   FRIEND_TEST_ALL_PREFIXES(DownloadManagerTest, StartDownload);
 
   ~DownloadFileManager();
 
   // Timer helpers for updating the UI about the current progress of a download.
   void StartUpdateTimer();
@@ skipping 34 matching lines @@
   // is controlled from the FILE thread, and posts updates to the UI thread.
   base::RepeatingTimer<DownloadFileManager> update_timer_;
 
   ResourceDispatcherHost* resource_dispatcher_host_;
   scoped_ptr<DownloadFileFactory> download_file_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadFileManager);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_MANAGER_H_