Change MockRead and MockWrite (et. al.) to take an IoMode enum, instead

Change MockRead and MockWrite (et. al.) to take an IoMode enum, instead
of a bool async.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123274

[Ryan Hamilton, 2012-02-17 22:39:59]

akalin: you only need to look at the jingle/ changes
jar:  Merry christmas :>

[akalin, 2012-02-17 22:41:53]

On 2012/02/17 22:39:59, Ryan Hamilton wrote:
> akalin: you only need to look at the jingle/ changes
> jar:  Merry christmas :>

jingle lgtm

[jar (doing other things), 2012-02-22 17:38:25]

This is a thankless job... and you did great.  I couldn't find any typos among
the TONS of changes you had to make.

Please fix the nits below.  The more I think about it, the more I think you
should change the |m| to |io_mode|.

Thanks again!  (so I guess it isn't completely thankless!).

LGTM

http://codereview.chromium.org/9425016/diff/75/net/http/http_network_transact...
File net/http/http_network_transaction_unittest.cc (left):

http://codereview.chromium.org/9425016/diff/75/net/http/http_network_transact...
net/http/http_network_transaction_unittest.cc:7932: return MockRead(false /*
async */, ERR_SSL_DECOMPRESSION_FAILURE_ALERT);
Cool/meaningless comment!   It could mean anything :-/

http://codereview.chromium.org/9425016/diff/75/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/9425016/diff/75/net/socket/socket_test_util.h#...
net/socket/socket_test_util.h:81: MockRead(IoMode m, int result) : mode(m),
result(result),
Style guide would probably argue against using "m" as an abbreviation for
mode.... but in this case, the code would probably look worse if you used
"mode".   

Either leave it as is.... or use the parameter name io_mode to initialize the
struct member |mode|.

http://codereview.chromium.org/9425016/diff/75/net/spdy/spdy_session_pool.cc
File net/spdy/spdy_session_pool.cc (right):

http://codereview.chromium.org/9425016/diff/75/net/spdy/spdy_session_pool.cc#...
net/spdy/spdy_session_pool.cc:258: }
nit: No need to add this when there is only one line.

Only exception is when they choose to do so pretty much every where else in the
file.... but on line 247 this is not done... so don't bother with this.

[Ryan Hamilton, 2012-02-22 17:50:10]

Thanks for the review (and the thanks :>).  There's still a long way to go to
get these tests really readable, but I'm happy to have moved the ball down the
field.

http://codereview.chromium.org/9425016/diff/75/net/http/http_network_transact...
File net/http/http_network_transaction_unittest.cc (left):

http://codereview.chromium.org/9425016/diff/75/net/http/http_network_transact...
net/http/http_network_transaction_unittest.cc:7932: return MockRead(false /*
async */, ERR_SSL_DECOMPRESSION_FAILURE_ALERT);
On 2012/02/22 17:38:25, jar wrote:
> Cool/meaningless comment!   It could mean anything :-/

Yeah, I love it. :|

http://codereview.chromium.org/9425016/diff/75/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/9425016/diff/75/net/socket/socket_test_util.h#...
net/socket/socket_test_util.h:81: MockRead(IoMode m, int result) : mode(m),
result(result),
On 2012/02/22 17:38:25, jar wrote:
> Style guide would probably argue against using "m" as an abbreviation for
> mode.... but in this case, the code would probably look worse if you used
> "mode".   
> 
> Either leave it as is.... or use the parameter name io_mode to initialize the
> struct member |mode|.

Done.

http://codereview.chromium.org/9425016/diff/75/net/spdy/spdy_session_pool.cc
File net/spdy/spdy_session_pool.cc (right):

http://codereview.chromium.org/9425016/diff/75/net/spdy/spdy_session_pool.cc#...
net/spdy/spdy_session_pool.cc:258: }
On 2012/02/22 17:38:25, jar wrote:
> nit: No need to add this when there is only one line.
> 
> Only exception is when they choose to do so pretty much every where else in
the
> file.... but on line 247 this is not done... so don't bother with this.
> 

Whoops!  I missed that before sending it to you.  This file shouldn't be part of
this CL and only changed as a result of some unrelated debugging I was doing. 
I've removed it from this CL.  (and reverted the trivial but wrong change :>)

[commit-bot: I haz the power, 2012-02-22 18:51:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425016/9001

[commit-bot: I haz the power, 2012-02-22 19:56:10]

Try job failure for 9425016-9001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-22 23:34:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425016/9001

[commit-bot: I haz the power, 2012-02-22 23:34:33]

Can't apply patch for file net/http/http_network_transaction_unittest.cc.
While running patch -p0 --forward --force;
patching file net/http/http_network_transaction_unittest.cc
Hunk #41 succeeded at 8483 (offset 6328 lines).
Hunk #42 FAILED at 2234.
Hunk #43 succeeded at 8920 with fuzz 2 (offset 6678 lines).
Hunk #44 FAILED at 2327.
Hunk #45 FAILED at 2340.
Hunk #46 FAILED at 2410.
Hunk #47 FAILED at 2422.
Hunk #48 FAILED at 2481.
Hunk #49 FAILED at 2491.
Hunk #50 FAILED at 2558.
Hunk #51 FAILED at 2628.
Hunk #52 FAILED at 2846.
Hunk #53 FAILED at 2868.
Hunk #54 FAILED at 2886.
Hunk #55 FAILED at 2974.
Hunk #56 FAILED at 3020.
Hunk #57 FAILED at 3103.
Hunk #58 FAILED at 3151.
Hunk #59 FAILED at 3197.
Hunk #60 FAILED at 3294.
Hunk #61 FAILED at 3342.
Hunk #62 FAILED at 3392.
Hunk #63 FAILED at 3447.
Hunk #64 FAILED at 3508.
Hunk #65 FAILED at 3603.
Hunk #66 FAILED at 3666.
Hunk #67 FAILED at 3684.
Hunk #68 FAILED at 3753.
Hunk #69 FAILED at 3795.
Hunk #70 FAILED at 3810.
Hunk #71 FAILED at 3874.
Hunk #72 FAILED at 3889.
Hunk #73 FAILED at 3956.
Hunk #74 FAILED at 4000.
Hunk #75 FAILED at 4015.
Hunk #76 FAILED at 4069.
Hunk #77 FAILED at 4085.
Hunk #78 FAILED at 4101.
Hunk #79 FAILED at 4181.
Hunk #80 FAILED at 4198.
Hunk #81 FAILED at 4263.
Hunk #82 FAILED at 4348.
Hunk #83 FAILED at 4400.
Hunk #84 FAILED at 4417.
Hunk #85 FAILED at 4425.
Hunk #86 FAILED at 4485.
Hunk #87 FAILED at 4537.
Hunk #88 FAILED at 4580.
Hunk #89 FAILED at 4591.
Hunk #90 FAILED at 4600.
Hunk #91 FAILED at 4649.
Hunk #92 FAILED at 4697.
Hunk #93 FAILED at 4710.
Hunk #94 FAILED at 4720.
Hunk #95 FAILED at 4771.
Hunk #96 FAILED at 4789.
Hunk #97 FAILED at 4797.
Hunk #98 FAILED at 4856.
Hunk #99 FAILED at 4934.
Hunk #100 FAILED at 4971.
Hunk #101 FAILED at 5008.
Hunk #102 FAILED at 5045.
Hunk #103 FAILED at 5084.
Hunk #104 FAILED at 5123.
Hunk #105 FAILED at 5161.
Hunk #106 FAILED at 5203.
Hunk #107 FAILED at 5242.
Hunk #108 FAILED at 5300.
Hunk #109 FAILED at 5308.
Hunk #110 FAILED at 5368.
Hunk #111 FAILED at 5434.
Hunk #112 FAILED at 5443.
Hunk #113 FAILED at 5780.
Hunk #114 FAILED at 5819.
Hunk #115 FAILED at 5849.
Hunk #116 FAILED at 5901.
Hunk #117 FAILED at 5922.
Hunk #118 FAILED at 5969.
Hunk #119 FAILED at 6004.
Hunk #120 succeeded at 9197 with fuzz 2 (offset 3143 lines).
Hunk #121 FAILED at 6109.
Hunk #122 FAILED at 6169.
Hunk #123 FAILED at 6388.
Hunk #124 FAILED at 6456.
Hunk #125 FAILED at 6519.
Hunk #126 FAILED at 6568.
Hunk #127 FAILED at 6617.
Hunk #128 FAILED at 6666.
Hunk #129 FAILED at 6711.
Hunk #130 FAILED at 6762.
Hunk #131 FAILED at 6784.
Hunk #132 FAILED at 6854.
Hunk #133 FAILED at 6871.
Hunk #134 FAILED at 6893.
Hunk #135 FAILED at 6973.
Hunk #136 FAILED at 7108.
Hunk #137 FAILED at 7135.
Hunk #138 FAILED at 7215.
Hunk #139 FAILED at 7239.
Hunk #140 FAILED at 7699.
Hunk #141 FAILED at 7929.
Hunk #142 FAILED at 7960.
Hunk #143 FAILED at 8007.
Hunk #144 FAILED at 8056.
Hunk #145 FAILED at 8109.
Hunk #146 FAILED at 8120.
Hunk #147 FAILED at 8172.
Hunk #148 FAILED at 8226.
Hunk #149 FAILED at 8306.
Hunk #150 FAILED at 8356.
Hunk #151 FAILED at 8411.
Hunk #152 FAILED at 8473.
Hunk #153 FAILED at 8517.
Hunk #154 FAILED at 8527.
Hunk #155 FAILED at 8570.
Hunk #156 FAILED at 8578.
Hunk #157 FAILED at 8605.
Hunk #158 FAILED at 8630.
Hunk #159 FAILED at 8643.
Hunk #160 FAILED at 8657.
Hunk #161 FAILED at 8735.
Hunk #162 FAILED at 8749.
Hunk #163 FAILED at 8762.
Hunk #164 FAILED at 8830.
Hunk #165 FAILED at 8964.
Hunk #166 FAILED at 8988.
Hunk #167 FAILED at 9118.
Hunk #168 FAILED at 9142.
Hunk #169 FAILED at 9211.
Hunk #170 FAILED at 9231.
Hunk #171 FAILED at 9241.
128 out of 171 hunks FAILED -- saving rejects to file
net/http/http_network_transaction_unittest.cc.rej

[commit-bot: I haz the power, 2012-02-23 00:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425016/17002

[commit-bot: I haz the power, 2012-02-23 03:37:46]

Try job failure for 9425016-17002 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-23 03:49:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425016/17002

[commit-bot: I haz the power, 2012-02-23 07:06:24]

Try job failure for 9425016-17002 (retry) (retry) on win_rel for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-23 16:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425016/17002

[commit-bot: I haz the power, 2012-02-23 18:08:08]

Change committed as 123274