Change MockRead and MockWrite (et. al.) to take an IoMode enum, instead

net/spdy/spdy_session_pool.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session_pool.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/values.h"
 #include "net/base/address_list.h"
@@ skipping 235 matching lines @@
   AddressList addresses;
   if (!LookupAddresses(host_port_proxy_pair, &addresses))
     return NULL;
   const addrinfo* address = addresses.head();
   while (address) {
     IPEndPoint endpoint;
     endpoint.FromSockAddr(address->ai_addr, address->ai_addrlen);
     address = address->ai_next;
 
     SpdyAliasMap::const_iterator it = aliases_.find(endpoint);
-    if (it == aliases_.end())
+    if (it == aliases_.end()) {
       continue;
+    }

[jar (doing other things), 2012/02/22 17:38:25]

nit: No need to add this when there is only one line.

Only exception is when they choose to do so pretty much every where else in the
file.... but on line 247 this is not done... so don't bother with this.

[Ryan Hamilton, 2012/02/22 17:50:10]

Whoops!  I missed that before sending it to you.  This file shouldn't be part of
this CL and only changed as a result of some unrelated debugging I was doing. 
I've removed it from this CL.  (and reverted the trivial but wrong change :>)

 
     // We found an alias.
     const HostPortProxyPair& alias_pair = it->second;
 
     // If the proxy settings match, we can reuse this session.
     if (!(alias_pair.second == host_port_proxy_pair.second))
       continue;
 
     SpdySessionList* list = GetSessionList(alias_pair);
     if (!list) {
@@ skipping 160 matching lines @@
     // Assumes there is only 1 element in the list
     SpdySessionList::iterator session_it = list->begin();
     const scoped_refptr<SpdySession>& session = *session_it;
     CHECK(session);
     if (!session->is_active())
       session->CloseSessionOnError(net::ERR_ABORTED, true);
   }
 }
 
 }  // namespace net