Fix most of the downloads api in incognito profiles

chrome/browser/download/download_extension_api.h

Index: chrome/browser/download/download_extension_api.h
diff --git a/chrome/browser/download/download_extension_api.h b/chrome/browser/download/download_extension_api.h
index 8eba05e62ec8120fef992d09b576f50038d7bc15..d3dac47419c26916b2b3371a258fbb826124e321 100644
--- a/chrome/browser/download/download_extension_api.h
+++ b/chrome/browser/download/download_extension_api.h
@@ -93,6 +93,8 @@ class SyncDownloadsFunction : public SyncExtensionFunction,
   // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
+  content::DownloadItem* GetItem(int id);
+
  private:
   DownloadsFunctionName function_;
 
@@ -111,6 +113,8 @@ class AsyncDownloadsFunction : public AsyncExtensionFunction,
   // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
+  content::DownloadItem* GetItem(int id);
+
  private:
   DownloadsFunctionName function_;
 
@@ -173,6 +177,8 @@ class DownloadsSearchFunction : public SyncDownloadsFunction {
   bool ParseOrderBy(const base::Value& order_by_value);
 
   scoped_ptr<DownloadQuery> query_;
+  bool include_on_the_record_;
+  bool include_incognito_;

[Matt Perry, 2012/05/14 22:57:11]

how is this different from include_incognito_ defined in ExtensionFunction?

[benjhayden, 2012/05/15 17:16:25]

It was caller-configurable instead of automatic based on user preferences and
usage. An extension could dynamically specify either incognito:none, or
incognito:only, or let it default to incognito:both.

I changed it to be automatic as you suggested.

   int get_id_;
   bool has_get_id_;