Fix most of the downloads api in incognito profiles

chrome/browser/download/download_extension_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 75 matching lines @@
  protected:
   explicit SyncDownloadsFunction(DownloadsFunctionName function);
   virtual ~SyncDownloadsFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
+  content::DownloadItem* GetItem(int id);
+
  private:
   DownloadsFunctionName function_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncDownloadsFunction);
 };
 
 class AsyncDownloadsFunction : public AsyncExtensionFunction,
                                public DownloadsFunctionInterface {
  protected:
   explicit AsyncDownloadsFunction(DownloadsFunctionName function);
   virtual ~AsyncDownloadsFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
+  content::DownloadItem* GetItem(int id);
+
  private:
   DownloadsFunctionName function_;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncDownloadsFunction);
 };
 
 class DownloadsDownloadFunction : public AsyncDownloadsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.download");
 
@@ skipping 42 matching lines @@
   virtual ~DownloadsSearchFunction();
 
   // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   bool ParseOrderBy(const base::Value& order_by_value);
 
   scoped_ptr<DownloadQuery> query_;
+  bool include_on_the_record_;
+  bool include_incognito_;

[Matt Perry, 2012/05/14 22:57:11]

how is this different from include_incognito_ defined in ExtensionFunction?

[benjhayden, 2012/05/15 17:16:25]

It was caller-configurable instead of automatic based on user preferences and
usage. An extension could dynamically specify either incognito:none, or
incognito:only, or let it default to incognito:both.

I changed it to be automatic as you suggested.

   int get_id_;
   bool has_get_id_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsSearchFunction);
 };
 
 class DownloadsPauseFunction : public SyncDownloadsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.pause");
 
@@ skipping 186 matching lines @@
   content::DownloadManager* manager_;
   ItemMap downloads_;
   ItemJsonMap item_jsons_;
   STLValueDeleter<ItemJsonMap> delete_item_jsons_;
   OnChangedStatMap on_changed_stats_;
   STLValueDeleter<OnChangedStatMap> delete_on_changed_stats_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionDownloadsEventRouter);
 };
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_