Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 9420007: Move RenderWidgetHostView into content namespace. Fix include paths. (Closed)

Created:
8 years, 10 months ago by Jói
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, aboxhall+watch_chromium.org, kkania, prasadt, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, jianli, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, robertshield, dtseng+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move RenderWidgetHostView into content namespace. Fix include paths. TBR=pkasting@chromium.org BUG=98716 Initial commit: 122753 Reverted (linux_chromeos_gtk build problem): r122755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122758

Patch Set 1 #

Patch Set 2 : Merge to LKGR. Fix compile issues on Mac and ChromeOS. #

Patch Set 3 : Fix copyright headers. #

Patch Set 4 : Fix include. #

Patch Set 5 : Fix linux_chromeos_gtk build issue not caught by trybots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -193 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock_window_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host_mac.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/renderer_accessibility_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_mac.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/renderer_host/render_widget_host_view.h View 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 4 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/interstitial_page_impl.cc View 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_helper.h View 5 chunks +13 lines, -11 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/render_widget_host_view.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_view.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Jói
8 years, 10 months ago (2012-02-16 16:10:29 UTC) #1
jam
lgtm also update chrome\browser\DEPS?
8 years, 10 months ago (2012-02-16 18:15:41 UTC) #2
Jói
> also update chrome\browser\DEPS? Done, and fixed small compile issues that trybots showed on a ...
8 years, 10 months ago (2012-02-20 10:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9420007/12001
8 years, 10 months ago (2012-02-20 10:06:21 UTC) #4
commit-bot: I haz the power
Presubmit check for 9420007-12001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-20 10:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9420007/6005
8 years, 10 months ago (2012-02-20 11:10:50 UTC) #6
commit-bot: I haz the power
Try job failure for 9420007-6005 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 10 months ago (2012-02-20 12:02:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9420007/12002
8 years, 10 months ago (2012-02-20 12:17:56 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-20 13:38:09 UTC) #9
Change committed as 122753

Powered by Google App Engine
This is Rietveld 408576698