Make GetNetworkList on Windows filter out 'down' interfaces, as on POSIX.

Make GetNetworkList on Windows filter out 'down' interfaces, as on POSIX.

The chrome_frame_net_tests wish to identify a non-loopback adapter to use during testing. Calling GetNetworkList is very convenient but currently on Windows it returns disconnected adapters without providing a means to detect the state of adapters. The POSIX version only returns connected adapters; this CL ports that behaviour to Windows.

BUG=114369
TEST=existing tests in net_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122883

[erikwright (departed), 2012-02-17 16:16:22]

Hi Wan-Teh,

[cc wez@, author of corresponding POSIX CL]

PTAL.

The corresponding POSIX change is here: http://codereview.chromium.org/7612012/

Thanks,

Erik

[Wez, 2012-02-17 18:49:15]

LGTM, FWIW.

[wtc, 2012-02-17 19:36:23]

LGTM.

http://codereview.chromium.org/9419053/diff/1/net/base/net_util_win.cc
File net/base/net_util_win.cc (right):

http://codereview.chromium.org/9419053/diff/1/net/base/net_util_win.cc#newcod...
net/base/net_util_win.cc:114: address = address->Next) {

Comparing this code with the GetNetworkList function for
POSIX, I still see two differences.

1. The POSIX code says "Skip interfaces with no address
configured".  I suspect that is handled by this for loop's
termination condition (address != NULL).

2. The POSIX code says "Skip loopback addresses configured
on non-loopback interfaces."  There is no equivalent code
here.  I am not sure if a non-loopback network interface
may have a loopback address configured though.

wez added that code in http://codereview.chromium.org/7612012.
You can ask him if it's necessary or just defensive
programming.

[Wez, 2012-02-17 20:36:35]

On 2012/02/17 19:36:23, wtc wrote:
> LGTM.
> 
> http://codereview.chromium.org/9419053/diff/1/net/base/net_util_win.cc
> File net/base/net_util_win.cc (right):
> 
>
http://codereview.chromium.org/9419053/diff/1/net/base/net_util_win.cc#newcod...
> net/base/net_util_win.cc:114: address = address->Next) {
> 
> Comparing this code with the GetNetworkList function for
> POSIX, I still see two differences.
> 
> 1. The POSIX code says "Skip interfaces with no address
> configured".  I suspect that is handled by this for loop's
> termination condition (address != NULL).
> 
> 2. The POSIX code says "Skip loopback addresses configured
> on non-loopback interfaces."  There is no equivalent code
> here.  I am not sure if a non-loopback network interface
> may have a loopback address configured though.
> 
> wez added that code in http://codereview.chromium.org/7612012.
> You can ask him if it's necessary or just defensive
> programming.

The POSIX code is based on similar code elsewhere in the Chrome tree.

I don't think Windows allows loopback addresses to be bound to non-loopback
network interfaces, which is why I didn't suggest it for this CL.

[commit-bot: I haz the power, 2012-02-21 20:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9419053/1

[commit-bot: I haz the power, 2012-02-21 22:00:25]

Change committed as 122883