Cleanup GetNetworkList.

Cleanup GetNetworkList.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96993

[Wez, 2011-08-11 00:07:37]

Revision to GetNetworkList() to make use of the LOOPBACK flag, and to filter out
loopback addresses.  Not sure whether the == INADDR_LOOPBACK test is suitable,
though - any better suggestions?

[Sergey Ulanov, 2011-08-11 02:06:37]

LGTM with two nits.

http://codereview.chromium.org/7612012/diff/1/net/base/net_util_posix.cc
File net/base/net_util_posix.cc (right):

http://codereview.chromium.org/7612012/diff/1/net/base/net_util_posix.cc#newc...
net/base/net_util_posix.cc:22: //#include <netdb.h>
remove commented line.

http://codereview.chromium.org/7612012/diff/1/net/base/net_util_posix.cc#newc...
net/base/net_util_posix.cc:92: if (addr->sa_family == AF_INET6) {
Add comment saying that we just filter loopback addresses here.

[commit-bot: I haz the power, 2011-08-13 04:42:13]

Presubmit check for 7612012-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/base/net_util_posix.cc

[Wez, 2011-08-13 04:45:13]

wtc: This is a follow up to the quick-fix for GetNetworkList() you reviewed the
other day.

[wtc, 2011-08-15 22:38:31]

LGTM.

http://codereview.chromium.org/7612012/diff/6001/net/base/net_util_posix.cc
File net/base/net_util_posix.cc (right):

http://codereview.chromium.org/7612012/diff/6001/net/base/net_util_posix.cc#n...
net/base/net_util_posix.cc:111: sizeof(interface->ifa_addr))) {
Change interface->ifa_addr (two occurrences) to your local
variable 'addr'.

BUG: the second argument to address.FromSockAddr() is wrong.
It should be the size of the particular kind of sockaddr
structure.  So it should be
  sizeof(struct sockaddr_in6)
or
  sizeof(struct sockaddr_in)
depending on the value of addr->sa_family.

What you're passing here, sizeof(interface->ifa_addr),
is the size of a pointer.

The reason it works is that address.FromSockAddr()
ignores the second argument.  Sigh.

I think you should pass a value that's more "correct",
such as sizeof(*addr) (note the '*'), or a value that's
clearly wrong, such as 0.  I would use a local variable
size_t address_length that's set in the if-else-if statement
on lines 93-103 above.