Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Issue 9416117: Android build: move content_unittests to default target. (Closed)

Created:
8 years, 10 months ago by John Grabowski
Modified:
8 years, 9 months ago
Reviewers:
Yaron, M-A Ruel
CC:
chromium-reviews, Peter Beverloo, Satish, M-A Ruel, Jeff Bailey (chromium), Nicolas Sylvain
Visibility:
Public.

Description

Android build: move content_unittests to default target. Also expand PRESUBMIT.py to include content files (e.g. everything). BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124108

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -14 lines 1 comment Download
M build/all_android.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
John Grabowski
Jeff / M-A / Nicholas: this change makes a clean Android build compile about 4x ...
8 years, 10 months ago (2012-02-22 23:03:10 UTC) #1
Yaron
lgtm Remember I'm a "lowly provisional" committer so I don't know if that's good enough ...
8 years, 10 months ago (2012-02-23 00:52:15 UTC) #2
M-A Ruel
lgtm http://chromiumcodereview.appspot.com/9416117/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://chromiumcodereview.appspot.com/9416117/diff/1/PRESUBMIT.py#newcode311 PRESUBMIT.py:311: preferred = ['win_rel', 'linux_rel', 'mac_rel', 'android'] To give ...
8 years, 10 months ago (2012-02-23 01:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9416117/1
8 years, 9 months ago (2012-02-28 22:40:22 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-02-29 03:52:04 UTC) #5
Change committed as 124108

Powered by Google App Engine
This is Rietveld 408576698