Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: PRESUBMIT.py

Issue 9416117: Android build: move content_unittests to default target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/all_android.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d0305eea199bf2f8dc333f80b3f85b4424a9e4fb..df8bfa76c881416e82b57c3f2e63a6a488491bb9 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -308,23 +308,10 @@ def GetPreferredTrySlaves(project, change):
only_objc_files = all(f.endswith(('.mm', '.m')) for f in affected_files)
if only_objc_files:
return ['mac_rel']
- preferred = ['win_rel', 'linux_rel', 'mac_rel']
+ preferred = ['win_rel', 'linux_rel', 'mac_rel', 'android']
M-A Ruel 2012/02/23 01:04:25 To give you an idea, right now there's 5 (5pm MTV
if any(f.endswith(('.h', '.cc', '.cpp', '.cxx')) for f in affected_files):
preferred.append('linux_clang')
aura_re = '_aura[^/]*[.][^/]*'
if any(re.search(aura_re, f) for f in affected_files):
preferred.append('linux_chromeos')
- # For bringup (staging of upstream work) we must be careful to not
- # overload Android infrastructure. Keeping Android try decisions in a
- # single location (instead of adding conditionals in base/, net/, ...)
- # will help us avoid doing so. For example, we are starting off with
- # 2 trybots (compared against ~45 for Mac and Linux).
- # If any file matches something compiled on the main waterfall
- # android builder, use the android try server.
- android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/',
- '^build/common.gypi$')
- for f in affected_files:
- if any(re.search(r, f) for r in android_re_list):
- preferred.append('android')
- break
return preferred
« no previous file with comments | « no previous file | build/all_android.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698