Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 9414030: Add chrome common files to android build (Closed)

Created:
8 years, 10 months ago by Isaac (away)
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Add chrome common files to android build Renaming two files from linux to posix to pull them into the android build, excluding them from the mac build to maintain status quo BUG=113487 TEST=None Transitioning to http://codereview.chromium.org/9414030/ so I can --no_presubmit for Isaac

Patch Set 1 #

Patch Set 2 : fixed gypi typo #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -184 lines) Patch
M chrome/chrome_common.gypi View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
D chrome/common/child_process_logging_linux.cc View 1 chunk +0 lines, -134 lines 0 comments Download
A + chrome/common/child_process_logging_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/common/chrome_version_info_linux.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A + chrome/common/chrome_version_info_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jam
lgtm
8 years, 10 months ago (2012-02-17 23:57:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/9414030/4001
8 years, 10 months ago (2012-02-18 08:14:07 UTC) #2
commit-bot: I haz the power
Presubmit check for 9414030-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-18 08:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/9414030/4001
8 years, 10 months ago (2012-02-18 09:15:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 9414030-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-18 09:15:16 UTC) #5
Isaac (away)
CQ seems to be ditching the patch because of the presubmit warnings. Our upstreaming doesn't ...
8 years, 10 months ago (2012-02-18 09:24:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/9414030/4001
8 years, 10 months ago (2012-02-18 09:46:43 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-18 09:46:46 UTC) #8
Presubmit check for 9414030-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    chrome/common/child_process_logging_posix.cc:66

Powered by Google App Engine
This is Rietveld 408576698