Issue 94002: Fix for Issue 317 - bug in string.replace(string, "$foo").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 94002: Fix for Issue 317 - bug in string.replace(string, "$foo"). (Closed)

Created:
11 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix for Issue 317 - bug in string.replace(string, "$foo"). Fix for Issue 317. Replace string with something containing dollar now works.

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -0 lines)			Patch
M	src/string.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-317.js	View	1 chunk	+31 lines, -0 lines	1 comment	Download
M	test/mjsunit/string-replace.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 8 months ago (2009-04-22 11:37:12 UTC) #3

LGTM

http://codereview.chromium.org/94002/diff/1/3
File test/mjsunit/regress/regress-317.js (right):

http://codereview.chromium.org/94002/diff/1/3#newcode30
Line 30: assertEquals("a$ec", "abc".replace("b", "$e"), "$e isn't meaningfull");
meaningful

Expand Messages | Collapse Messages