src/string.js - Issue 94002: Fix for Issue 317 - bug in string.replace(string, "$foo").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 94002: Fix for Issue 317 - bug in string.replace(string, "$foo"). (Closed)

Patch Set: Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index d9d6d6981194963b3a4709d9daace07b45718bf4..3ccad9a21a9d445217d639b602191f6e0a3f7c65 100644

--- a/src/string.js

+++ b/src/string.js

@@ -304,6 +304,8 @@ function ExpandReplacement(string, subject, matchInfo, builder) {

builder.add('$');

--position;

}

+ } else {

+ builder.add('$');

}

} else {

builder.add('$');

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-317.js » ('j') | test/mjsunit/regress/regress-317.js » ('J')