Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9395027: Add linux_clang to default try set (Closed)

Created:
8 years, 10 months ago by Dan Beam
Modified:
8 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add linux_clang to default try set so when one runs `git try` or `gcl try` it will add linux_clang automatically. TEST=Less tree breakage because of not trying changes on clang first. BUG=None NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122041

Patch Set 1 #

Patch Set 2 : adding .cxx and manually tested #

Total comments: 2

Patch Set 3 : AffectedFiles() -> LocalPaths() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M PRESUBMIT.py View 1 2 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
Tell me if there's somebody else I should be giving this to.
8 years, 10 months ago (2012-02-14 23:43:46 UTC) #1
M-A Ruel
https://chromiumcodereview.appspot.com/9395027/diff/2001/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/9395027/diff/2001/PRESUBMIT.py#newcode337 PRESUBMIT.py:337: affected_files = [f.LocalPath() for f in change.AffectedFiles()] You want ...
8 years, 10 months ago (2012-02-14 23:45:17 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/9395027/diff/2001/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/9395027/diff/2001/PRESUBMIT.py#newcode337 PRESUBMIT.py:337: affected_files = [f.LocalPath() for f in change.AffectedFiles()] On 2012/02/14 ...
8 years, 10 months ago (2012-02-14 23:50:28 UTC) #3
M-A Ruel
lgtm
8 years, 10 months ago (2012-02-15 00:00:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9395027/2002
8 years, 10 months ago (2012-02-15 02:47:45 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 04:21:37 UTC) #6
Change committed as 122041

Powered by Google App Engine
This is Rietveld 408576698