Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: PRESUBMIT.py

Issue 9395027: Add linux_clang to default try set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AffectedFiles() -> LocalPaths() Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index fd1df328f8825376e7c0fd28236bcaa54559f58c..e6ef99b612efef5db337604e25f2acb53409b30c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -334,13 +334,15 @@ def CheckChangeOnCommit(input_api, output_api):
def GetPreferredTrySlaves(project, change):
- only_objc_files = all(
- f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles())
+ affected_files = change.LocalPaths()
+ only_objc_files = all(f.endswith(('.mm', '.m')) for f in affected_files)
if only_objc_files:
return ['mac_rel']
preferred = ['win_rel', 'linux_rel', 'mac_rel']
+ if any(f.endswith(('.h', '.cc', '.cpp', '.cxx')) for f in affected_files):
+ preferred.append('linux_clang')
aura_re = '_aura[^/]*[.][^/]*'
- if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()):
+ if any(re.search(aura_re, f) for f in affected_files):
preferred.append('linux_chromeos')
# For bringup (staging of upstream work) we must be careful to not
# overload Android infrastructure. Keeping Android try decisions in a
@@ -351,8 +353,8 @@ def GetPreferredTrySlaves(project, change):
# android builder, use the android try server.
android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/',
'^build/common.gypi$')
- for f in change.AffectedFiles():
- if any(re.search(r, f.LocalPath()) for r in android_re_list):
+ for f in affected_files:
+ if any(re.search(r, f) for r in android_re_list):
preferred.append('android')
break
return preferred
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698