Issue 9391008: Add a missing hard_dependency to google_update.gyp, as it generates headers used by other targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9391008: Add a missing hard_dependency to google_update.gyp, as it generates headers used by other targets. (Closed)

Created:
8 years, 10 months ago by Ryan Sleevi

Modified:
8 years, 10 months ago

Reviewers:
Bernhard Bauer, rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a missing hard_dependency to google_update.gyp, as it generates headers used by other targets. BUG=none TEST=Chromium.lkgr Win builder goes green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121726

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	google_update/google_update.gyp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Ricardo, FYI and/or for your consideration, since I suspect it may flake during your PST ...

8 years, 10 months ago (2012-02-13 18:37:53 UTC) #2

rvargas (doing something else)

rbstmp lgtm. http://codereview.chromium.org/9391008/diff/1/google_update/google_update.gyp File google_update/google_update.gyp (right): http://codereview.chromium.org/9391008/diff/1/google_update/google_update.gyp#newcode15 google_update/google_update.gyp:15: 'hard_dependency': 1, Please add a comment explaining ...

8 years, 10 months ago (2012-02-13 18:49:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9391008/3

8 years, 10 months ago (2012-02-13 18:54:18 UTC) #4

Change committed as 121726

Expand Messages | Collapse Messages