google_update/google_update.gyp - Issue 9391008: Add a missing hard_dependency to google_update.gyp, as it generates headers used by other targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_update/google_update.gyp

Issue 9391008: Add a missing hard_dependency to google_update.gyp, as it generates headers used by other targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_update/google_update.gyp

diff --git a/google_update/google_update.gyp b/google_update/google_update.gyp

index 20fcbb621c1fe15b202f383ce4e981085fe96749..c3e76d804774065e75343e1a7b445872d807039d 100644

--- a/google_update/google_update.gyp

+++ b/google_update/google_update.gyp

@@ -12,6 +12,9 @@

'<(SHARED_INTERMEDIATE_DIR)/google_update/google_update_idl.h',

'<(SHARED_INTERMEDIATE_DIR)/google_update/google_update_idl_i.c',

+ # This target exports a hard dependency because dependent targets may

+ # include google_update_idl.h, a generated header.

+ 'hard_dependency': 1,

'msvs_settings': {

'VCMIDLTool': {

'OutputDirectory': '<(SHARED_INTERMEDIATE_DIR)/google_update',

« no previous file with comments | « no previous file | no next file » | no next file with comments »