Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/proxy/ppp_instance_private_proxy_unittest.cc

Issue 9391006: PPAPI: Add unlocking for PPP calls and callbacks. Add more locking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added documentation Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/ppb_message_loop_proxy.cc ('K') | « ppapi/proxy/ppp_instance_private_proxy.cc ('k') | ppapi/proxy/ppp_messaging_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppp_instance_private_proxy_unittest.cc
diff --git a/ppapi/proxy/ppp_instance_private_proxy_unittest.cc b/ppapi/proxy/ppp_instance_private_proxy_unittest.cc
index 6b87f1245728f144b50566f3a53414e207911c0e..fc48993b86427b05a0f9eaf28acdb84f70cd94ff 100644
--- a/ppapi/proxy/ppp_instance_private_proxy_unittest.cc
+++ b/ppapi/proxy/ppp_instance_private_proxy_unittest.cc
@@ -58,7 +58,8 @@ PP_Var GetInstanceObject(PP_Instance /*instance*/) {
// The 1 ref we got from CreateObject will be passed to the host. We want to
// have a ref of our own.
printf("GetInstanceObject called\n");
- PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);
+ plugin_var_deprecated_if()->AddRef(instance_obj);
+ //PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);
brettw 2012/02/13 20:52:34 Delete this line?
dmichael (off chromium) 2012/02/13 21:15:33 Done.
return instance_obj;
}
« ppapi/proxy/ppb_message_loop_proxy.cc ('K') | « ppapi/proxy/ppp_instance_private_proxy.cc ('k') | ppapi/proxy/ppp_messaging_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698