SPDY - trun off spdy/2.1 by default. It could be enabled

SPDY - trun off spdy/2.1 by default. It could be enabled
with command line option --use-spdy=flow-control.

The following are the two CL's that are related to spdy/2.1

http://codereview.chromium.org/8892026
http://codereview.chromium.org/9252029/

R=wtc
BUG=114105
TEST=test gmail, docs with spdy proxy enabled and disabled.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121964

[ramant (doing other things), 2012-02-14 00:18:44]

Hi Wan-Teh,
  Tested accessing moma, mail and docs with SPDY proxy enabled and didn't see
any issues. Will enable SPDY/2.1 only after making sure SPDY/2.1 works with SPDY
proxy (we are investigating whether it is a server or client side bug).

thanks,
raman

[wtc, 2012-02-14 02:26:05]

Patch Set 2 LGTM.  I studied the two old CLs you mentioned.
As far as I can tell, this CL correctly turns off SPDY/2.1.

http://codereview.chromium.org/9390027/diff/5/net/http/http_network_layer.cc
File net/http/http_network_layer.cc (right):

http://codereview.chromium.org/9390027/diff/5/net/http/http_network_layer.cc#...
net/http/http_network_layer.cc:132: pair.protocol = NPN_SPDY_2;

We should also come up with a better way to specify the
forced alternate protocol.

[ramant (doing other things), 2012-02-14 18:46:04]

Hi Wan-Teh and willchan,
  Fixed the unittests (with alternate protocol) to use spdy/2. Yesterday Wan-Teh
and I thought, we will use SPDY/2 only in the tests that have failed.

  The other option is to revert http://codereview.chromium.org/9252029/ CL.

  Would appreciate your comments.

thanks much,
raman

[wtc, 2012-02-14 20:22:18]

Patch Set 5 LGTM.

http://codereview.chromium.org/9390027/diff/15002/net/http/http_stream_factor...
File net/http/http_stream_factory.cc (right):

http://codereview.chromium.org/9390027/diff/15002/net/http/http_stream_factor...
net/http/http_stream_factory.cc:87: for (int i = NPN_SPDY_2; i <= NPN_SPDY_2;
++i) {

Another approach is to use a global variable or configuration
setting to control the upper bound of this for loop.

Then we can set the upper bound to NPN_SPDY_21 for unit tests,
and to NPN_SPDY_2 for Chrome.

[commit-bot: I haz the power, 2012-02-14 21:48:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/9390027/15002

[commit-bot: I haz the power, 2012-02-14 23:26:45]

Change committed as 121964