Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 8892026: SPDY - add support for spdy/2.1 to support flow control. (Closed)

Created:
9 years ago by ramant (doing other things)
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

SPDY - add support for spdy/2.1 to support flow control. 1) Add spdy/2.1 as a supported NPN protocol. 2) Advertise that chrome supports spdy/2.1 when --flow-control (spdy flag) is enabled. 3) When SPDY protocol is negotiated, enable flow_control in spdy_session if spdy/2.1 is negotiated as NPN protocol. BUG=106911 R=willchan TEST=network unit tests and if possible test with SPDY 2.1 server with command line flag --flow-control. This CL is same as the following CL. Implemented changes suggested by willchan in the following review. http://codereview.chromium.org/8890044/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -20 lines) Patch
M net/http/http_network_layer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +16 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket.h View 3 chunks +8 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/spdy/spdy_http_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +11 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
Hi willchan, Sorry for the trouble. This CL is same as the following CL which ...
9 years ago (2011-12-10 03:27:27 UTC) #1
willchan no longer on Chromium
LGTM On 2011/12/10 03:27:27, ramant wrote: > Hi willchan, > Sorry for the trouble. This ...
9 years ago (2011-12-10 03:34:22 UTC) #2
commit-bot: I haz the power
9 years ago (2011-12-10 04:49:12 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698