Issue 9385040: Updated home screen to match new UI mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9385040: Updated home screen to match new UI mocks. (Closed)

Created:
8 years, 10 months ago by Jamie

Modified:
8 years, 10 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated home screen to match new UI mocks. BUG=115350 TEST=Home screen looks shinier. Rest of UI still works, but may look a bit funky for a while. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123122

Patch Set 1 #

Patch Set 2 : Removed unused CSS. #

Patch Set 3 : Miscellaneous clean-ups. #

Total comments: 2

Patch Set 4 : Fixed typo. #

Patch Set 5 : Fixed copyright header. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4618 lines, -222 lines)			Patch
M	remoting/resources/chromoting128.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/resources/chromoting16.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/resources/chromoting48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/webapp/_locales/en/messages.json	View	1 2 3	4 chunks	+12 lines, -12 lines	0 comments	Download
M	remoting/webapp/host_list.js	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/webapp/host_table_entry.js	View	1 2	4 chunks	+18 lines, -17 lines	0 comments	Download
M	remoting/webapp/main.css	View	1 2	11 chunks	+4494 lines, -85 lines	0 comments	Download
M	remoting/webapp/main.html	View		15 chunks	+96 lines, -109 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

A small CL for you :) It's not as scary as it looks. https://chromiumcodereview.appspot.com/9385040/diff/7002/remoting/webapp/main.css File ...

8 years, 10 months ago (2012-02-22 22:33:46 UTC) #1

garykac

8 years, 10 months ago (2012-02-22 23:00:21 UTC) #2

LGTM

http://codereview.chromium.org/9385040/diff/7002/remoting/webapp/_locales/en/...
File remoting/webapp/_locales/en/messages.json (right):

http://codereview.chromium.org/9385040/diff/7002/remoting/webapp/_locales/en/...
remoting/webapp/_locales/en/messages.json:218: "description": "Sub-title for the
remote assistence section of the UI, which contains buttons to share this
computer or to connect to another computer, both on a one-off basis."
assistance

Expand Messages | Collapse Messages