Remove knowledge about SSLClientAuthHandler from chrome. Instead a callback is given to the embed...

Remove knowledge about SSLClientAuthHandler from chrome. Instead a callback is given to the embedder to be run when the certificate is available.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121733

[jam, 2012-02-10 20:50:55]

Matt: you looked like you're the last person who made meaty changes in this
area, so sending to you. please let me know if you think someone else should
review this.

[jam, 2012-02-13 18:58:48]

Avi: I haven't heard from Matt, can you take a look?

[Avi (use Gerrit), 2012-02-13 20:10:37]

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
File chrome/browser/ssl/ssl_client_auth_observer.h (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
chrome/browser/ssl/ssl_client_auth_observer.h:32: // cancelled. Dervied classes
must use this instead of caching the callback
s/Dervied/Derived/

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
File chrome/browser/ssl/ssl_client_auth_requestor_mock.h (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
chrome/browser/ssl/ssl_client_auth_requestor_mock.h:20: class
SSLClientAuthRequestorMock
"Requestor" is not English. Yet
http://code.google.com/codesearch#search/&exact_package=chromium&q=requestor
returns lots of results. Can you point me to a source of enlightenment?

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
File chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:52: -
(id)initObserver:(const net::HttpNetworkSession*)networkSession
initWithObserver (and all the places that's used)

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:54: callback:(const
base::Callback<void(net::X509Certificate*)>&) callback;
80 columns. Even in ObjC. Also, there's no space after the param type. Lucky
they cancel each other out.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:155: callback:(const
base::Callback<void(net::X509Certificate*)>&) callback {
same 80 col issue, same removal of space to fix it.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/views/ssl_...
File chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
(right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/views/ssl_...
chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc:64:
base::Callback<void(net::X509Certificate*)> x;
x?

[jam, 2012-02-13 20:59:00]

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
File chrome/browser/ssl/ssl_client_auth_observer.h (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
chrome/browser/ssl/ssl_client_auth_observer.h:32: // cancelled. Dervied classes
must use this instead of caching the callback
On 2012/02/13 20:10:37, Avi wrote:
> s/Dervied/Derived/

Done.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
File chrome/browser/ssl/ssl_client_auth_requestor_mock.h (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ssl/ssl_clien...
chrome/browser/ssl/ssl_client_auth_requestor_mock.h:20: class
SSLClientAuthRequestorMock
On 2012/02/13 20:10:37, Avi wrote:
> "Requestor" is not English. Yet
> http://code.google.com/codesearch#search/&exact_package=chromium&q=requestor
> returns lots of results. Can you point me to a source of enlightenment?

I didn't think about it that much :) It looks like our code uses both, and
they're interchangeable per http://www.merriam-webster.com/dictionary/requestor.
if you want i can rename this to requester

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
File chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm (right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:52: -
(id)initObserver:(const net::HttpNetworkSession*)networkSession
On 2012/02/13 20:10:37, Avi wrote:
> initWithObserver (and all the places that's used)

Done.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:54: callback:(const
base::Callback<void(net::X509Certificate*)>&) callback;
On 2012/02/13 20:10:37, Avi wrote:
> 80 columns. Even in ObjC. Also, there's no space after the param type. Lucky
> they cancel each other out.

Done.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm:155: callback:(const
base::Callback<void(net::X509Certificate*)>&) callback {
On 2012/02/13 20:10:37, Avi wrote:
> same 80 col issue, same removal of space to fix it.

Done.

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/views/ssl_...
File chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
(right):

http://codereview.chromium.org/9384014/diff/7021/chrome/browser/ui/views/ssl_...
chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc:64:
base::Callback<void(net::X509Certificate*)> x;
On 2012/02/13 20:10:37, Avi wrote:
> x?

i think that was missing a ctrl+, removed

[Avi (use Gerrit), 2012-02-13 21:02:55]

LGTM