Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ppapi/tests/test_url_loader.cc

Issue 9381010: Convert resources to take an instance key instead of an Instance*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: USELESS PATCH TITLE Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_socket_private.cc ('k') | ppapi/tests/test_url_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_url_loader.cc
diff --git a/ppapi/tests/test_url_loader.cc b/ppapi/tests/test_url_loader.cc
index 2b0a66b2e18d599bac442a210d6c4839621a149b..984fee082ddb4cfc3c9ddce6e6621ffade4dfece 100644
--- a/ppapi/tests/test_url_loader.cc
+++ b/ppapi/tests/test_url_loader.cc
@@ -169,7 +169,7 @@ std::string TestURLLoader::LoadAndCompareBody(
const std::string& expected_body) {
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
int32_t rv = loader.Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
@@ -251,7 +251,7 @@ std::string TestURLLoader::GetReachableAbsoluteURL(
// Get the absolute page URL and replace the test case file name
// with the given one.
pp::Var document_url(
- pp::Var::PassRef(),
+ pp::PASS_REF,
testing_interface_->GetDocumentURL(instance_->pp_instance(),
NULL));
std::string url(document_url.AsString());
@@ -306,7 +306,7 @@ int32_t TestURLLoader::OpenTrusted(const pp::URLRequestInfo& request) {
int32_t TestURLLoader::Open(const pp::URLRequestInfo& request,
bool trusted) {
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
if (trusted)
url_loader_trusted_interface_->GrantUniversalAccess(loader.pp_resource());
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
@@ -439,7 +439,7 @@ std::string TestURLLoader::TestStreamToFile() {
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
int32_t rv = loader.Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
@@ -728,7 +728,7 @@ std::string TestURLLoader::TestAuditURLRedirect() {
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
int32_t rv = loader.Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
@@ -777,7 +777,7 @@ std::string TestURLLoader::TestAbortCalls() {
// Abort |Open()|.
{
callback.reset_run_count();
- rv = pp::URLLoader(*instance_).Open(request, callback);
+ rv = pp::URLLoader(instance_).Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
if (callback.run_count() > 0)
@@ -795,7 +795,7 @@ std::string TestURLLoader::TestAbortCalls() {
{
char buf[2] = { 0 };
{
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
rv = loader.Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
@@ -836,7 +836,7 @@ std::string TestURLLoader::TestUntendedLoad() {
request.SetRecordDownloadProgress(true);
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
- pp::URLLoader loader(*instance_);
+ pp::URLLoader loader(instance_);
int32_t rv = loader.Open(request, callback);
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("URLLoader::Open force_async", rv);
« no previous file with comments | « ppapi/tests/test_tcp_socket_private.cc ('k') | ppapi/tests/test_url_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698