Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: ppapi/tests/test_url_util.cc

Issue 9381010: Convert resources to take an instance key instead of an Instance*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: USELESS PATCH TITLE Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_url_loader.cc ('k') | ppapi/tests/test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_url_util.cc
diff --git a/ppapi/tests/test_url_util.cc b/ppapi/tests/test_url_util.cc
index 179aeeb56d5dba944b0e2d8364ac6b150ae671ec..5de683ff926e32e7d0445ec7dd21f9cb41f4a57b 100644
--- a/ppapi/tests/test_url_util.cc
+++ b/ppapi/tests/test_url_util.cc
@@ -108,18 +108,18 @@ std::string TestURLUtil::TestIsSameSecurityOrigin() {
std::string TestURLUtil::TestDocumentCanRequest() {
// This is hard to test, but we can at least verify we can't request
// some random domain.
- ASSERT_FALSE(util_->DocumentCanRequest(*instance_, "http://evil.com/"));
+ ASSERT_FALSE(util_->DocumentCanRequest(instance_, "http://evil.com/"));
PASS();
}
std::string TestURLUtil::TestDocumentCanAccessDocument() {
// This is hard to test, but we can at least verify we can access ourselves.
- ASSERT_TRUE(util_->DocumentCanAccessDocument(*instance_, *instance_));
+ ASSERT_TRUE(util_->DocumentCanAccessDocument(instance_, instance_));
PASS();
}
std::string TestURLUtil::TestGetDocumentURL() {
- pp::Var url = util_->GetDocumentURL(*instance_);
+ pp::Var url = util_->GetDocumentURL(instance_);
ASSERT_TRUE(url.is_string());
pp::VarPrivate window = instance_->GetWindowObject();
pp::Var href = window.GetProperty("location").GetProperty("href");
@@ -130,7 +130,7 @@ std::string TestURLUtil::TestGetDocumentURL() {
}
std::string TestURLUtil::TestGetPluginInstanceURL() {
- pp::Var url = util_->GetPluginInstanceURL(*instance_);
+ pp::Var url = util_->GetPluginInstanceURL(instance_);
ASSERT_TRUE(url.is_string());
// see test_case.html
ASSERT_EQ(url.AsString(), "http://a.b.c/test");
« no previous file with comments | « ppapi/tests/test_url_loader.cc ('k') | ppapi/tests/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698