Issue 9380002: Add a mock-hyphenation functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9380002: Add a mock-hyphenation functions. (Closed)

Created:
8 years, 10 months ago by Hironori Bono

Modified:
8 years, 8 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a mock-hyphenation functions. This change adds a couple of mock functions (canHyphenate and lastHyphenLocation) to be used by DumpRenderTree. These functions emulate the behavior of Apple DumpRenderTree. BUG=47083 TEST=fast/text/hyphenate-character.html and fast/text/hyphens.html

Patch Set 1 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -0 lines)			Patch
	M	webkit/support/test_webkit_platform_support.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	webkit/support/test_webkit_platform_support.cc	View		1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings Tony, This is the first step to fix a long-lasting issue. To move this ...

8 years, 10 months ago (2012-02-10 10:10:58 UTC) #1

tony

8 years, 10 months ago (2012-02-10 18:34:11 UTC) #2

What is the benefit to using mock data just to pass the layout tests?  I would
rather we just fail the tests until we have a real implementation.

Expand Messages | Collapse Messages