Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webkit/tools/test_shell/simple_file_system.h

Issue 9372044: Refactor FileSystemOperation to take callback for each method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reflected kinuko's comments + Fixture for failing-Write -> Cancel pattern. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/sandbox_mount_point_provider.cc ('k') | webkit/tools/test_shell/simple_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/simple_file_system.h
diff --git a/webkit/tools/test_shell/simple_file_system.h b/webkit/tools/test_shell/simple_file_system.h
index 82c2e01232e2e087850a37dff0de7237be01a0e2..81a61ab12e1070682840bda05d12ec323e61e3ce 100644
--- a/webkit/tools/test_shell/simple_file_system.h
+++ b/webkit/tools/test_shell/simple_file_system.h
@@ -10,6 +10,8 @@
#include "base/memory/weak_ptr.h"
#include "base/scoped_temp_dir.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebFileSystem.h"
+#include "webkit/fileapi/file_system_context.h"
+#include "webkit/fileapi/file_system_operation_interface.h"
#include "webkit/fileapi/file_system_types.h"
#include <vector>
@@ -21,7 +23,6 @@ class WebURL;
namespace fileapi {
class FileSystemContext;
-class FileSystemOperationInterface;
}
class SimpleFileSystem
@@ -82,7 +83,31 @@ class SimpleFileSystem
private:
// Helpers.
fileapi::FileSystemOperationInterface* GetNewOperation(
- const WebKit::WebURL& path, WebKit::WebFileSystemCallbacks* callbacks);
+ const WebKit::WebURL& path);
+
+ // Callback Handlers
+ fileapi::FileSystemOperationInterface::StatusCallback FinishHandler(
+ WebKit::WebFileSystemCallbacks* callbacks);
+ fileapi::FileSystemOperationInterface::GetMetadataCallback GetMetadataHandler(
+ WebKit::WebFileSystemCallbacks* callbacks);
+ fileapi::FileSystemOperationInterface::ReadDirectoryCallback
+ ReadDirectoryHandler(WebKit::WebFileSystemCallbacks* callbacks);
+ fileapi::FileSystemContext::OpenFileSystemCallback OpenFileSystemHandler(
+ WebKit::WebFileSystemCallbacks* callbacks);
+ void DidFinish(WebKit::WebFileSystemCallbacks* callbacks,
+ base::PlatformFileError result);
+ void DidGetMetadata(WebKit::WebFileSystemCallbacks* callbacks,
+ base::PlatformFileError result,
+ const base::PlatformFileInfo& info,
+ const FilePath& platform_path);
+ void DidReadDirectory(
+ WebKit::WebFileSystemCallbacks* callbacks,
+ base::PlatformFileError result,
+ const std::vector<base::FileUtilProxy::Entry>& entries,
+ bool has_more);
+ void DidOpenFileSystem(WebKit::WebFileSystemCallbacks* callbacks,
+ base::PlatformFileError result,
+ const std::string& name, const GURL& root);
// A temporary directory for FileSystem API.
ScopedTempDir file_system_dir_;
« no previous file with comments | « webkit/fileapi/sandbox_mount_point_provider.cc ('k') | webkit/tools/test_shell/simple_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698