webkit/fileapi/sandbox_mount_point_provider.cc - Issue 9372044: Refactor FileSystemOperation to take callback for each method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/sandbox_mount_point_provider.cc

Issue 9372044: Refactor FileSystemOperation to take callback for each method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reflected kinuko's comments + Fixture for failing-Write -> Cancel pattern. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/sandbox_mount_point_provider.cc

diff --git a/webkit/fileapi/sandbox_mount_point_provider.cc b/webkit/fileapi/sandbox_mount_point_provider.cc

index 1b2dc96ed4efe038765230289427eb2ca4621328..e79624eaa791cc7accb97f7327dcb27736a2583f 100644

--- a/webkit/fileapi/sandbox_mount_point_provider.cc

+++ b/webkit/fileapi/sandbox_mount_point_provider.cc

@@ -16,7 +16,6 @@

#include "base/metrics/histogram.h"

#include "googleurl/src/gurl.h"

#include "net/base/net_util.h"

-#include "webkit/fileapi/file_system_callback_dispatcher.h"

#include "webkit/fileapi/file_system_operation.h"

#include "webkit/fileapi/file_system_operation_context.h"

#include "webkit/fileapi/file_system_options.h"

@@ -416,10 +415,9 @@ SandboxMountPointProvider::CreateFileSystemOperation(

const GURL& origin_url,

FileSystemType file_system_type,

const FilePath& virtual_path,

- scoped_ptr<FileSystemCallbackDispatcher> dispatcher,

base::MessageLoopProxy* file_proxy,

FileSystemContext* context) const {

- return new FileSystemOperation(dispatcher.Pass(), file_proxy, context);

+ return new FileSystemOperation(file_proxy, context);

}

FilePath SandboxMountPointProvider::old_base_path() const {