webkit/fileapi/file_system_url_request_job.h - Issue 9372044: Refactor FileSystemOperation to take callback for each method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_url_request_job.h

Issue 9372044: Refactor FileSystemOperation to take callback for each method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reflected kinuko's comments + Fixture for failing-Write -> Cancel pattern. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/file_system_url_request_job.h

diff --git a/webkit/fileapi/file_system_url_request_job.h b/webkit/fileapi/file_system_url_request_job.h

index b980b5618ec149c3e782a9e230e7835aa4185bdf..62cb82041bfd5366d5e4d45aabc65a4d540fc9ef 100644

--- a/webkit/fileapi/file_system_url_request_job.h

+++ b/webkit/fileapi/file_system_url_request_job.h

@@ -55,7 +55,8 @@ class FileSystemURLRequestJob : public net::URLRequestJob {

virtual ~FileSystemURLRequestJob();

void StartAsync();

- void DidGetMetadata(const base::PlatformFileInfo& file_info,

+ void DidGetMetadata(base::PlatformFileError error_code,

+ const base::PlatformFileInfo& file_info,

const FilePath& platform_path);

void DidOpen(base::PlatformFileError error_code,

base::PassPlatformFile file, bool created);