webkit/fileapi/file_system_test_helper.cc - Issue 9372044: Refactor FileSystemOperation to take callback for each method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_test_helper.cc

Issue 9372044: Refactor FileSystemOperation to take callback for each method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reflected kinuko's comments + Fixture for failing-Write -> Cancel pattern. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/file_system_test_helper.cc

diff --git a/webkit/fileapi/file_system_test_helper.cc b/webkit/fileapi/file_system_test_helper.cc

index 4bb40118065b3343118e6fa7a8b18555d9d438e5..0d31f1d434b15a4bd20f2f88f2d762c0047f2745 100644

--- a/webkit/fileapi/file_system_test_helper.cc

+++ b/webkit/fileapi/file_system_test_helper.cc

@@ -8,7 +8,6 @@

#include "base/message_loop.h"

#include "base/message_loop_proxy.h"

#include "googleurl/src/gurl.h"

-#include "webkit/fileapi/file_system_callback_dispatcher.h"

#include "webkit/fileapi/file_system_context.h"

#include "webkit/fileapi/file_system_operation.h"

#include "webkit/fileapi/file_system_operation_context.h"

@@ -141,14 +140,11 @@ int64 FileSystemTestOriginHelper::ComputeCurrentOriginUsage() const {

return size;

}

-FileSystemOperation* FileSystemTestOriginHelper::NewOperation(

- FileSystemCallbackDispatcher* callback_dispatcher) {

+FileSystemOperation* FileSystemTestOriginHelper::NewOperation() {

DCHECK(file_system_context_.get());

DCHECK(file_util_);

FileSystemOperation* operation =

- new FileSystemOperation(scoped_ptr<FileSystemCallbackDispatcher>(

- callback_dispatcher),

- base::MessageLoopProxy::current(),

+ new FileSystemOperation(base::MessageLoopProxy::current(),

file_system_context_.get());

operation->set_override_file_util(file_util_);

InitializeOperationContext(operation->file_system_operation_context());